Bug 1429904 - Remove unused operator< from StackKey and FrameKey. r=njn
authorMarkus Stange <mstange@themasta.com>
Tue, 27 Feb 2018 22:41:35 -0500
changeset 762393 f96a75472e04d4bb37af3b6e5fbfec543eb81c16
parent 762392 d1a509b4cdfbec084aa5bf57f91038813f0cc645
child 762394 f1408af12dfa9ab53f4da597220c32c27331375f
push id101169
push userluca.greco@alcacoop.it
push dateFri, 02 Mar 2018 12:32:00 +0000
reviewersnjn
bugs1429904
milestone60.0a1
Bug 1429904 - Remove unused operator< from StackKey and FrameKey. r=njn nsGenericHashKey never calls this operator, as far as I can tell. MozReview-Commit-ID: NDybMI8DOA
tools/profiler/core/ProfileBufferEntry.h
--- a/tools/profiler/core/ProfileBufferEntry.h
+++ b/tools/profiler/core/ProfileBufferEntry.h
@@ -198,19 +198,16 @@ public:
      : mJITAddress(mozilla::Some(aJITAddress))
      , mJITDepth(mozilla::Some(aJITDepth))
     {
       mHash = Hash();
     }
 
     uint32_t Hash() const;
     bool operator==(const FrameKey& aOther) const;
-    bool operator<(const FrameKey& aOther) const {
-      return mHash < aOther.mHash;
-    }
 
   private:
     uint32_t mHash;
   };
 
   struct StackKey {
     mozilla::Maybe<uint32_t> mPrefixStackIndex;
     uint32_t mFrameIndex;
@@ -228,20 +225,16 @@ public:
 
     uint32_t Hash() const { return mHash; }
 
     bool operator==(const StackKey& aOther) const
     {
       return mPrefixStackIndex == aOther.mPrefixStackIndex &&
              mFrameIndex == aOther.mFrameIndex;
     }
-    bool operator<(const StackKey& aOther) const
-    {
-      return mHash < aOther.mHash;
-    }
 
   private:
     uint32_t mHash;
   };
 
   explicit UniqueStacks();
 
   // Needs to be called when using a UniqueStacks object again after having