Bug NODE - Pre: Don't throw inscrutable errors when failing to post_build. draft
authorNick Alexander <nalexander@mozilla.com>
Thu, 05 Apr 2018 16:42:38 -0700
changeset 795811 f950de93d8b8707dc9b7dd4bfcb1e79566837991
parent 795256 cf3ee14023483cbbb57129479537c713e22c1980
child 795812 6c0fccdfb560d6acb7d8135a94a795615aea9b8c
push id110091
push userbmo:dmose@mozilla.org
push dateWed, 16 May 2018 16:58:05 +0000
milestone62.0a1
Bug NODE - Pre: Don't throw inscrutable errors when failing to post_build.
python/mozbuild/mozbuild/controller/building.py
--- a/python/mozbuild/mozbuild/controller/building.py
+++ b/python/mozbuild/mozbuild/controller/building.py
@@ -1113,17 +1113,17 @@ class BuildDriver(MozbuildObject):
             try:
                 config = self.config_environment
                 active_backend = config.substs.get('BUILD_BACKENDS', [None])[0]
                 if active_backend:
                     backend_cls = get_backend_class(active_backend)(config)
                     new_status = backend_cls.post_build(self, output, jobs, verbose, status)
                     status = new_status
             except Exception as ex:
-                self.log(logging.DEBUG, 'post_build', {'ex': ex},
+                self.log(logging.DEBUG, 'post_build', {'ex': str(ex)},
                          "Unable to run active build backend's post-build step; " +
                          "failing the build due to exception: {ex}.")
                 if not status:
                     # If the underlying build provided a failing status, pass
                     # it through; otherwise, fail.
                     status = 1
 
             monitor.finish(record_usage=status == 0)