Bug 1429904 - Remove mHash which is now unused. It was only used by FrameKey::operator<. r?njn draft
authorMarkus Stange <mstange@themasta.com>
Tue, 27 Feb 2018 23:06:31 -0500
changeset 762099 f5074e4a6df03782e8ae18384c71f868ab8b0942
parent 762098 9ba70eaf74c5b367aa303dc02a4d6bdd4a0101fe
child 762100 b366941fbef50c430114f3cf9f41008027f6761b
push id101088
push userbmo:mstange@themasta.com
push dateThu, 01 Mar 2018 20:52:26 +0000
reviewersnjn
bugs1429904
milestone60.0a1
Bug 1429904 - Remove mHash which is now unused. It was only used by FrameKey::operator<. r?njn MozReview-Commit-ID: 5Jc6EYmoZfS
tools/profiler/core/ProfileBufferEntry.h
--- a/tools/profiler/core/ProfileBufferEntry.h
+++ b/tools/profiler/core/ProfileBufferEntry.h
@@ -176,41 +176,35 @@ public:
     mozilla::Maybe<unsigned> mLine;
     mozilla::Maybe<unsigned> mCategory;
     mozilla::Maybe<JITAddress> mJITAddress;
     mozilla::Maybe<uint32_t> mJITDepth;
 
     explicit FrameKey(const char* aLocation)
      : mLocation(aLocation)
     {
-      mHash = Hash();
     }
 
     FrameKey(const FrameKey& aToCopy)
      : mLocation(aToCopy.mLocation)
      , mLine(aToCopy.mLine)
      , mCategory(aToCopy.mCategory)
      , mJITAddress(aToCopy.mJITAddress)
      , mJITDepth(aToCopy.mJITDepth)
     {
-      mHash = Hash();
     }
 
     FrameKey(const JITAddress& aJITAddress, uint32_t aJITDepth)
      : mJITAddress(mozilla::Some(aJITAddress))
      , mJITDepth(mozilla::Some(aJITDepth))
     {
-      mHash = Hash();
     }
 
     uint32_t Hash() const;
     bool operator==(const FrameKey& aOther) const;
-
-  private:
-    uint32_t mHash;
   };
 
   struct StackKey {
     mozilla::Maybe<uint32_t> mPrefixStackIndex;
     uint32_t mFrameIndex;
 
     explicit StackKey(uint32_t aFrame)
      : mFrameIndex(aFrame)