Backed out changeset 15d237d39fb8 (bug 1332690) for asserts in DocAccessibleParent.cpp a=backout
authorWes Kocher <wkocher@mozilla.com>
Wed, 08 Feb 2017 16:19:20 -0800
changeset 480952 f505911eb333d5ae8c2bf5c44f7b85add6450b53
parent 480951 56b122662f91478828ef5214ba9d280fe11d0e72
child 480953 1416203fa889c537f99daa0a7e7844e3ff0b1e52
child 480969 c152aac7d0b649cd891a81f7ed3291ea2761cd82
child 480996 55a4f51891156537b2681cd2942dcfb358a9c2c9
child 481021 edcdb21c49d82035b01ef3e37695045002574580
child 481047 3aff1b913efbd4e389c4131365991ff629e799a4
child 481048 5297177b79432fdabeb477ec4c832ee992294af4
child 481080 8d6effe0ff6e62d49b37e425a8598b36c4985f4f
child 481085 65a7a14895c94615eb9cf0e0275548697eb548b3
child 481088 fdeed28dc92003ef3e5bf0e70954ac9af7c9bd78
child 481094 e1ba75db8f89c18ea34a66db7fed76af0c51c8e3
child 481107 b430b88512571e9116a5056f130c88a09c09c5fe
child 481111 26c6263edd65babdf90f2ff00f6e26e2697f04d6
child 481117 07a2fc52d8a48962068afeab161c212798e5a4e5
child 481120 440d09b720b874439c7ca99b26334e1511aecda0
child 481131 a51dbb757c003b8f93ca26fd871ba92e2967cc72
child 481209 62ffc0541c4d755199b313b0eed361f9e2c985ab
child 481249 f16cfe3a09be2641fbd789ecbfa8812f9e5034e7
child 481251 08ac91ab0cf5e68e052f7d638e25f273a58dc810
child 481260 2858afc97f2f34a087343b50af9bda042ab1853c
child 481267 ad2825aabceef6623237ec4692911f520801ea4c
child 481314 37c5d348b5c2a112f52930336fa0e7f5e4af93a4
child 481467 c6f82e5acb4e40553a573b2804334479176d5a17
child 481606 f95c5ca38e4671d8b53a24fec5b22a9a3fc12213
child 481619 478016651d62323c295469f91c1fbe4e7e74891e
child 481621 cea680b3e3c33130696d10aa5f046c2fb8522b73
child 481623 7c37467768ed20b1c22f255a2dd27ece3894b120
child 481631 a4eef0715bef3b01af49ba3bfcfcbdd3e44cd321
child 481642 41df9743c90413accff5712e8b19af2a26aca7ab
child 481650 1612974860401e1dcc417d6401b6c67479b658a3
child 481653 ba7122c826f42f85475e566577b8eb4d544243c7
child 481669 1b5c8ef47610bddb433a8f5f103742a813e144bc
child 481672 86ae6323c0a41fe6c357f257e04ff40c16fbedc6
child 481673 74dcbe0c027fe6ca7baaeae3248cdebaf8785e0d
child 481680 70021546b94adc4d1bc5524ee139709869d9c0ee
child 482223 f4ac27b2d9e26b8d9330e7b4839ccd05286c1098
child 483314 01c901149a7cb88021adf02cb44287d6ece8bcb1
child 483583 29f75c933141e2ef0d8f22f7aefe71a779fc370b
child 485195 9f71b2db17a99dce76f9c326edf00340decc7de4
child 485196 59fd0cef0ec3bf01ff28c49556ff290d2d42dbdd
child 489056 b32eef7cb98ad9a99debbc1d8617b9789348a5d9
push id44667
push userbmo:tschneider@mozilla.com
push dateThu, 09 Feb 2017 00:31:11 +0000
reviewersbackout
bugs1332690
milestone54.0a1
backs out15d237d39fb8958775af7e06b8f5e3c5d435b41e
Backed out changeset 15d237d39fb8 (bug 1332690) for asserts in DocAccessibleParent.cpp a=backout MozReview-Commit-ID: BwRMVLvOSde
accessible/ipc/DocAccessibleParent.cpp
--- a/accessible/ipc/DocAccessibleParent.cpp
+++ b/accessible/ipc/DocAccessibleParent.cpp
@@ -406,23 +406,18 @@ DocAccessibleParent::RecvBindChildDoc(PD
 
 ipc::IPCResult
 DocAccessibleParent::AddChildDoc(DocAccessibleParent* aChildDoc,
                                  uint64_t aParentID, bool aCreating)
 {
   // We do not use GetAccessible here because we want to be sure to not get the
   // document it self.
   ProxyEntry* e = mAccessibles.GetEntry(aParentID);
-  if (!e) {
-#ifdef DEBUG
+  if (!e)
     return IPC_FAIL(this, "binding to nonexistant proxy!");
-#else
-    return IPC_OK();
-#endif
-  }
 
   ProxyAccessible* outerDoc = e->mProxy;
   MOZ_ASSERT(outerDoc);
 
   // OuterDocAccessibles are expected to only have a document as a child.
   // However for compatibility we tolerate replacing one document with another
   // here.
   if (outerDoc->ChildrenCount() > 1 ||