Bug 1369614 - Add test fail condition to reftest of interpolating stroke-dasharray between px and percentage. r?hiro draft
authorMantaroh Yoshinaga <mantaroh@gmail.com>
Mon, 07 Aug 2017 17:55:55 +0900
changeset 641551 f0e0933da740a1c9050aa18bc729b8b6bbfeca4a
parent 641444 bb8de16ce00cb57b587a14c210ecc7505f366328
child 641552 9b4df08b43614a78177035069d5f2de8cc8440ce
push id72578
push userbmo:mantaroh@gmail.com
push dateMon, 07 Aug 2017 08:57:24 +0000
reviewershiro
bugs1369614, 1258270, 1386967
milestone57.0a1
Bug 1369614 - Add test fail condition to reftest of interpolating stroke-dasharray between px and percentage. r?hiro Current stylo uses LengthOrPercentage::Calc for interpolation between length and percentage, but neither gecko nor stylo will not support the calc value for stroke-dasharray. (bug 1258270 / bug 1386967) So current stylo will not animate this types. In this bug, we make stroke-dasharray interpolation between length and percentage as discrete type until we properly support calc() for stroke-dasharray (bug 1258270 / bug 1386967), as a result, rendering results of this type matches with gecko. In current reftest.list, we specified 'fails == <test> <reference>' condition. If we specified this condition, result will fail when rendering result of gecko and stylo is same even if rendering result of <test> is different from <reference> on stylo. So we need to add 'fails-if(!styloVsGecko) == <test> <reference>' condition. MozReview-Commit-ID: FBuJM254ZdS
layout/reftests/svg/smil/style/reftest.list
--- a/layout/reftests/svg/smil/style/reftest.list
+++ b/layout/reftests/svg/smil/style/reftest.list
@@ -109,29 +109,30 @@ skip-if(!styloVsGecko) == anim-css-strok
 == anim-css-strokewidth-1-by-no-no.svg        anim-css-strokewidth-1-ref.svg
 == anim-css-strokewidth-1-from-by-no-no.svg   anim-css-strokewidth-1-ref.svg
 == anim-css-strokewidth-1-from-to-no-no.svg   anim-css-strokewidth-1-ref.svg
 == anim-css-strokewidth-1-to-no-no.svg        anim-css-strokewidth-1-ref.svg
 
 # 'stroke-width' property, from/by/to with percent values
 # XXXdholbert the mixed pct + px tests fail right now, because we need calc()
 # in order to interpolate between pct and non-pct values, and we don't yet
-# support calc() for stroke-width & other SVG-specific properties (Bug 594933).
+# support calc() for stroke-width & other SVG-specific properties. (Bug 1258270
+# for gecko, Bug 1386967 for stylo)
 == anim-css-strokewidth-1-by-pct-pct.svg      anim-css-strokewidth-1-ref.svg
-fails == anim-css-strokewidth-1-by-pct-px.svg       anim-css-strokewidth-1-ref.svg
-fails == anim-css-strokewidth-1-by-px-pct.svg       anim-css-strokewidth-1-ref.svg
+fails-if(!styloVsGecko) == anim-css-strokewidth-1-by-pct-px.svg       anim-css-strokewidth-1-ref.svg
+fails-if(!styloVsGecko) == anim-css-strokewidth-1-by-px-pct.svg       anim-css-strokewidth-1-ref.svg
 == anim-css-strokewidth-1-from-by-pct-pct.svg anim-css-strokewidth-1-ref.svg
-fails == anim-css-strokewidth-1-from-by-pct-px.svg  anim-css-strokewidth-1-ref.svg
-fails == anim-css-strokewidth-1-from-by-px-pct.svg  anim-css-strokewidth-1-ref.svg
+fails-if(!styloVsGecko) == anim-css-strokewidth-1-from-by-pct-px.svg  anim-css-strokewidth-1-ref.svg
+fails-if(!styloVsGecko) == anim-css-strokewidth-1-from-by-px-pct.svg  anim-css-strokewidth-1-ref.svg
 == anim-css-strokewidth-1-from-to-pct-pct.svg anim-css-strokewidth-1-ref.svg
-fails == anim-css-strokewidth-1-from-to-pct-px.svg  anim-css-strokewidth-1-ref.svg
-fails == anim-css-strokewidth-1-from-to-px-pct.svg  anim-css-strokewidth-1-ref.svg
+fails-if(!styloVsGecko) == anim-css-strokewidth-1-from-to-pct-px.svg  anim-css-strokewidth-1-ref.svg
+fails-if(!styloVsGecko) == anim-css-strokewidth-1-from-to-px-pct.svg  anim-css-strokewidth-1-ref.svg
 == anim-css-strokewidth-1-to-pct-pct.svg      anim-css-strokewidth-1-ref.svg
-fails == anim-css-strokewidth-1-to-pct-px.svg       anim-css-strokewidth-1-ref.svg
-fails == anim-css-strokewidth-1-to-px-pct.svg       anim-css-strokewidth-1-ref.svg
+fails-if(!styloVsGecko) == anim-css-strokewidth-1-to-pct-px.svg       anim-css-strokewidth-1-ref.svg
+fails-if(!styloVsGecko) == anim-css-strokewidth-1-to-px-pct.svg       anim-css-strokewidth-1-ref.svg
 
 # 'stroke-width' property, from/by/to with em values
 == anim-css-strokewidth-1-by-px-em.svg        anim-css-strokewidth-1-ref.svg
 == anim-css-strokewidth-1-by-em-em.svg        anim-css-strokewidth-1-ref.svg
 == anim-css-strokewidth-1-by-em-px.svg        anim-css-strokewidth-1-ref.svg
 == anim-css-strokewidth-1-from-by-px-em.svg   anim-css-strokewidth-1-ref.svg
 == anim-css-strokewidth-1-from-by-em-em.svg   anim-css-strokewidth-1-ref.svg
 == anim-css-strokewidth-1-from-by-em-px.svg   anim-css-strokewidth-1-ref.svg