Bug 1350887 - Skip recommended Marionette prefs for reftests; r?whimboo draft
authorAndreas Tolfsen <ato@mozilla.com>
Tue, 04 Apr 2017 16:34:03 +0100
changeset 556065 ecb1b454285cbce6044c7232ba64a655f1f97a95
parent 556064 39e98771948eb7baa8df3a68fc1023c573964374
child 556066 cb8d7ac746540d2f7ad50bf57dd27ab5be1761df
push id52427
push userbmo:ato@mozilla.com
push dateWed, 05 Apr 2017 09:39:48 +0000
Bug 1350887 - Skip recommended Marionette prefs for reftests; r?whimboo The recommended Marionette preferences for use in automation are not so useful when testing the browser itself. Many of the tests for Firefox have highly specific requirements, and setting the recommended Marionette preferences could for these mean a deterioration of test coverage. The majority of test harnesses utilising Marionette use it to install unsigned add-ons at runtime, and these preferences are not relevant in this context. To avoid an unfortunate and unintended regression in test coverage, we skip using the recommended Marionette preferences when we test the browser itself. MozReview-Commit-ID: 4DeHZfQEX7d
--- a/layout/tools/reftest/reftest-preferences.js
+++ b/layout/tools/reftest/reftest-preferences.js
@@ -126,8 +126,13 @@ user_pref("testing.supports.moz-bool-pre
 // gigabytes).
 user_pref("places.history.enabled", false);
 // For Firefox 52 only, ESR will support non-Flash plugins while release will
 // not, so we keep testing the non-Flash pathways
 user_pref("plugin.load_flash_only", false);
 user_pref("media.openUnsupportedTypeWithExternalApp", false);
+// Disable all recommended Marionette preferences for Gecko tests.
+// The prefs recommended by Marionette are typically geared towards
+// consumer automation; not vendor testing.
+user_pref("marionette.prefs.recommended", false);