Bug 1337986 - Build dump_syms before any syms target. r=glandium
authorChris Manchester <cmanchester@mozilla.com>
Mon, 10 Apr 2017 10:27:49 -0700
changeset 560221 e7a38558e8e25e100527f02c30bd0ff83d1b36c8
parent 560220 eb9139a092c035e1fa0fb9e6576e6205c93abfa3
child 560222 dc1e93d948191a44effb69decec536cecdc2af87
push id53365
push userjichen@mozilla.com
push dateTue, 11 Apr 2017 08:35:12 +0000
reviewersglandium
bugs1337986
milestone55.0a1
Bug 1337986 - Build dump_syms before any syms target. r=glandium MozReview-Commit-ID: CXlmMVMhzmf
config/recurse.mk
--- a/config/recurse.mk
+++ b/config/recurse.mk
@@ -81,16 +81,21 @@ recurse_compile: $(syms_targets)
 endif
 endif
 
 # Create a separate rule that depends on every 'syms' target so that
 # symbols can be dumped on demand locally.
 .PHONY: recurse_syms
 recurse_syms: $(syms_targets)
 
+# Ensure dump_syms gets built before any syms targets, all of which depend on it.
+ifneq (,$(filter toolkit/crashreporter/google-breakpad/src/tools/%/dump_syms/host,$(compile_targets)))
+$(syms_targets): $(filter toolkit/crashreporter/google-breakpad/src/tools/%/dump_syms/host,$(compile_targets))
+endif
+
 # The compile tier has different rules from other tiers.
 ifneq ($(CURRENT_TIER),compile)
 
 # Recursion rule for all directories traversed for all subtiers in the
 # current tier.
 $(addsuffix /$(CURRENT_TIER),$(CURRENT_DIRS)): %/$(CURRENT_TIER):
 	$(call RECURSE,$(CURRENT_TIER),$*)