Bug 1405637 - Remove duplicated test browser_webconsole_notifications;r=nchevobbe
Test was already migrated in
Bug 1304003 to browser_webconsole_observer_notifications.js.
MozReview-Commit-ID: DyfVJ49ksSd
--- a/devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
+++ b/devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
@@ -324,18 +324,16 @@ skip-if = true # Bug 1404886
[browser_webconsole_network_attach.js]
[browser_webconsole_network_exceptions.js]
[browser_webconsole_network_messages_expand.js]
[browser_webconsole_network_messages_openinnet.js]
[browser_webconsole_network_requests_from_chrome.js]
[browser_webconsole_network_reset_filter.js]
[browser_webconsole_nodes_highlight.js]
[browser_webconsole_nodes_select.js]
-[browser_webconsole_notifications.js]
-skip-if = true # Bug 1405637
[browser_webconsole_object_in_sidebar.js]
[browser_webconsole_object_inspector.js]
[browser_webconsole_object_inspector_entries.js]
[browser_webconsole_observer_notifications.js]
[browser_webconsole_optimized_out_vars.js]
[browser_webconsole_output_copy.js]
subsuite = clipboard
skip-if = true # Bug 1404364
deleted file mode 100644
--- a/devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_notifications.js
+++ /dev/null
@@ -1,77 +0,0 @@
-/* -*- indent-tabs-mode: nil; js-indent-level: 2 -*- */
-/* vim: set ft=javascript ts=2 et sw=2 tw=80: */
-/* Any copyright is dedicated to the Public Domain.
- * http://creativecommons.org/publicdomain/zero/1.0/ */
-
-"use strict";
-
-const TEST_URI = "data:text/html;charset=utf-8,<p>Web Console test for " +
- "notifications";
-
-add_task(function* () {
- yield loadTab(TEST_URI);
-
- let consoleOpened = defer();
- let gotEvents = waitForEvents(consoleOpened.promise);
- yield openConsole().then(() => {
- consoleOpened.resolve();
- });
-
- yield gotEvents;
-});
-
-function waitForEvents(onConsoleOpened) {
- let deferred = defer();
-
- function webConsoleCreated(id) {
- Services.obs.removeObserver(observer, "web-console-created");
- ok(HUDService.getHudReferenceById(id), "We have a hud reference");
- content.wrappedJSObject.console.log("adding a log message");
- }
-
- function webConsoleDestroyed(id) {
- Services.obs.removeObserver(observer, "web-console-destroyed");
- ok(!HUDService.getHudReferenceById(id), "We do not have a hud reference");
- executeSoon(deferred.resolve);
- }
-
- function webConsoleMessage(id, nodeID) {
- Services.obs.removeObserver(observer, "web-console-message-created");
- ok(id, "we have a console ID");
- is(typeof nodeID, "string", "message node id is a string");
- onConsoleOpened.then(closeConsole);
- }
-
- let observer = {
-
- QueryInterface: XPCOMUtils.generateQI([Ci.nsIObserver]),
-
- observe: function observe(subject, topic, data) {
- subject = subject.QueryInterface(Ci.nsISupportsString);
-
- switch (topic) {
- case "web-console-created":
- webConsoleCreated(subject.data);
- break;
- case "web-console-destroyed":
- webConsoleDestroyed(subject.data);
- break;
- case "web-console-message-created":
- webConsoleMessage(subject, data);
- break;
- default:
- break;
- }
- },
-
- init: function init() {
- Services.obs.addObserver(this, "web-console-created");
- Services.obs.addObserver(this, "web-console-destroyed");
- Services.obs.addObserver(this, "web-console-message-created");
- }
- };
-
- observer.init();
-
- return deferred.promise;
-}
--- a/devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_observer_notifications.js
+++ b/devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_observer_notifications.js
@@ -1,22 +1,22 @@
/* -*- indent-tabs-mode: nil; js-indent-level: 2 -*- */
/* vim: set ft=javascript ts=2 et sw=2 tw=80: */
/* Any copyright is dedicated to the Public Domain.
* http://creativecommons.org/publicdomain/zero/1.0/ */
"use strict";
const TEST_URI = "data:text/html;charset=utf-8,<p>Web Console test for " +
- "obeserver notifications";
+ "observer notifications";
let created = false;
let destroyed = false;
-add_task(async function() {
+add_task(async function () {
setupObserver();
await openNewTabAndConsole(TEST_URI);
await waitFor(() => created);
await closeTabAndToolbox(gBrowser.selectedTab);
await waitFor(() => destroyed);
});