Bug 1405087: Also nix -moz-user-input: enabled. r?bz draft
authorEmilio Cobos Álvarez <emilio@crisal.io>
Sun, 11 Feb 2018 21:12:26 +0100
changeset 754787 e2e4abf6efdd449b9a3b6e098b07f669ab725798
parent 754786 f9176e09db35ed312250ccbf8cf8f46a3b50af24
child 754788 b7f7c500611b168a4f945acc7460d6e0a575f3ad
push id98999
push userbmo:emilio@crisal.io
push dateWed, 14 Feb 2018 09:56:37 +0000
reviewersbz
bugs1405087, 760876
milestone60.0a1
Bug 1405087: Also nix -moz-user-input: enabled. r?bz It only has one use, has the same effect that "auto", and should have no effect in <a> elements anyway (plus it's not overridden or used in that file at all anyway), so we can remove its only use instead. I can also change that use to "auto" if you want, but bug 760876 doesn't mention -moz-user-input at all, so I think this is quite useless... MozReview-Commit-ID: 8EzQlzu9drE
devtools/client/themes/webconsole.css
devtools/shared/css/generated/properties-db.js
layout/style/nsCSSProps.cpp
layout/style/nsStyleConsts.h
layout/style/test/property_database.js
servo/components/style/properties/longhand/pointing.mako.rs
--- a/devtools/client/themes/webconsole.css
+++ b/devtools/client/themes/webconsole.css
@@ -9,17 +9,16 @@
   --error-background-color: #FFEBEB;
   --warning-background-color: #FFFFC8;
 }
 
 /* General output styles */
 
 a {
   -moz-user-focus: normal;
-  -moz-user-input: enabled;
   cursor: pointer;
   text-decoration: underline;
 }
 
 /* Workaround for Bug 575675 - FindChildWithRules aRelevantLinkVisited
  * assertion when loading HTML page with links in XUL iframe */
 *:visited { }
 
@@ -1272,9 +1271,9 @@ body #output-container {
 }
 
 .sidebar-contents .object-inspector {
   min-width: 100%;
 }
 
 .theme-twisty {
   cursor: default;
-}
\ No newline at end of file
+}
--- a/devtools/shared/css/generated/properties-db.js
+++ b/devtools/shared/css/generated/properties-db.js
@@ -1383,18 +1383,16 @@ exports.CSS_PROPERTIES = {
   "-moz-user-input": {
     "isInherited": true,
     "subproperties": [
       "-moz-user-input"
     ],
     "supports": [],
     "values": [
       "auto",
-      "disabled",
-      "enabled",
       "inherit",
       "initial",
       "none",
       "unset"
     ]
   },
   "-moz-user-modify": {
     "isInherited": true,
--- a/layout/style/nsCSSProps.cpp
+++ b/layout/style/nsCSSProps.cpp
@@ -2130,17 +2130,16 @@ const KTableEntry nsCSSProps::kUserFocus
   { eCSSKeyword_select_after,   uint8_t(StyleUserFocus::SelectAfter) },
   { eCSSKeyword_select_same,    uint8_t(StyleUserFocus::SelectSame) },
   { eCSSKeyword_select_menu,    uint8_t(StyleUserFocus::SelectMenu) },
   { eCSSKeyword_UNKNOWN,        -1 }
 };
 
 const KTableEntry nsCSSProps::kUserInputKTable[] = {
   { eCSSKeyword_none,     StyleUserInput::None },
-  { eCSSKeyword_enabled,  StyleUserInput::Enabled },
   { eCSSKeyword_auto,     StyleUserInput::Auto },
   { eCSSKeyword_UNKNOWN,  -1 }
 };
 
 const KTableEntry nsCSSProps::kUserModifyKTable[] = {
   { eCSSKeyword_read_only,  StyleUserModify::ReadOnly },
   { eCSSKeyword_read_write, StyleUserModify::ReadWrite },
   { eCSSKeyword_write_only, StyleUserModify::WriteOnly },
--- a/layout/style/nsStyleConsts.h
+++ b/layout/style/nsStyleConsts.h
@@ -200,17 +200,16 @@ enum class StyleUserSelect : uint8_t {
   Auto,     // internal value - please use nsFrame::IsSelectable()
   MozAll,   // force selection of all children, unless an ancestor has NONE set - bug 48096
   MozText,  // Like TEXT, except that it won't get overridden by ancestors having ALL.
 };
 
 // user-input
 enum class StyleUserInput : uint8_t {
   None,
-  Enabled,
   Auto,
 };
 
 // user-modify
 enum class StyleUserModify : uint8_t {
   ReadOnly,
   ReadWrite,
   WriteOnly,
--- a/layout/style/test/property_database.js
+++ b/layout/style/test/property_database.js
@@ -2627,17 +2627,17 @@ var gCSSProperties = {
     other_values: [ "normal", "ignore", "select-all", "select-before", "select-after", "select-same", "select-menu" ],
     invalid_values: []
   },
   "-moz-user-input": {
     domProp: "MozUserInput",
     inherited: true,
     type: CSS_TYPE_LONGHAND,
     initial_values: [ "auto" ],
-    other_values: [ "none", "enabled" ],
+    other_values: [ "none" ],
     invalid_values: []
   },
   "-moz-user-modify": {
     domProp: "MozUserModify",
     inherited: true,
     type: CSS_TYPE_LONGHAND,
     initial_values: [ "read-only" ],
     other_values: [ "read-write", "write-only" ],
--- a/servo/components/style/properties/longhand/pointing.mako.rs
+++ b/servo/components/style/properties/longhand/pointing.mako.rs
@@ -16,17 +16,17 @@
 // NB: `pointer-events: auto` (and use of `pointer-events` in anything that isn't SVG, in fact)
 // is nonstandard, slated for CSS4-UI.
 // TODO(pcwalton): SVG-only values.
 ${helpers.single_keyword("pointer-events", "auto none", animation_value_type="discrete",
                          extra_gecko_values="visiblepainted visiblefill visiblestroke visible painted fill stroke all",
                          flags="APPLIES_TO_PLACEHOLDER",
                          spec="https://www.w3.org/TR/SVG11/interact.html#PointerEventsProperty")}
 
-${helpers.single_keyword("-moz-user-input", "auto none enabled",
+${helpers.single_keyword("-moz-user-input", "auto none",
                          products="gecko", gecko_ffi_name="mUserInput",
                          gecko_enum_prefix="StyleUserInput",
                          animation_value_type="discrete",
                          spec="Nonstandard (https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-user-input)")}
 
 ${helpers.single_keyword("-moz-user-modify", "read-only read-write write-only",
                          products="gecko", gecko_ffi_name="mUserModify",
                          gecko_enum_prefix="StyleUserModify",