Bug 1319237 - Make GeckoDriver#setWindowSize synchronous; r=automatedtester draft
authorAndreas Tolfsen <ato@mozilla.com>
Mon, 21 Nov 2016 23:44:22 +0100
changeset 481995 e0a52169e8bb272eb26019ffcacb708700eb37bd
parent 481994 53db6f2b0089588b94064f6b09dab2bdd9fe619e
child 481996 637edd708738129a7639c5fccdaab943e48fb92c
push id44976
push userbmo:ato@mozilla.com
push dateFri, 10 Feb 2017 20:32:49 +0000
reviewersautomatedtester
bugs1319237
milestone54.0a1
Bug 1319237 - Make GeckoDriver#setWindowSize synchronous; r=automatedtester Return from the Set Window Size command only after the window resize DOM event has occurred. MozReview-Commit-ID: 7ygZuNJZzq2
testing/marionette/driver.js
--- a/testing/marionette/driver.js
+++ b/testing/marionette/driver.js
@@ -2418,23 +2418,30 @@ GeckoDriver.prototype.getWindowSize = fu
 
 /**
  * Set the size of the browser window currently in focus.
  *
  * Not supported on B2G. The supplied width and height values refer to
  * the window outerWidth and outerHeight values, which include scroll
  * bars, title bars, etc.
  */
-GeckoDriver.prototype.setWindowSize = function (cmd, resp) {
+GeckoDriver.prototype.setWindowSize = function* (cmd, resp) {
   assert.firefox()
 
   let {width, height} = cmd.parameters;
+
   let win = this.getCurrentWindow();
-  win.resizeTo(width, height);
-  this.getWindowSize(cmd, resp);
+  yield new Promise(resolve => {
+    win.addEventListener("resize", resolve, {once: true});
+    win.resizeTo(width, height);
+  });
+  return {
+    width: win.outerWidth,
+    height: win.outerHeight,
+  };
 };
 
 /**
  * Maximizes the user agent window as if the user pressed the maximise
  * button.
  *
  * Not Supported on B2G or Fennec.
  */