Bug 1470068 - Rename LOCAL_EME_SOURCES in ProductAddonChecker to LOCAL_GMP_SOURCES. r=cpearce
authorHenrik Skupin <mail@hskupin.info>
Thu, 21 Jun 2018 07:42:59 +0200
changeset 809345 dff46afaa69c7b7d4a53d2d7728346d016b78adb
parent 809344 4e4be76218d898d7d068e1420e52713e9ff8f86f
child 809346 97d67e0eaccff918811b6f76fdf8c331bacf143e
push id113651
push userkgupta@mozilla.com
push dateThu, 21 Jun 2018 22:29:49 +0000
reviewerscpearce
bugs1470068
milestone62.0a1
Bug 1470068 - Rename LOCAL_EME_SOURCES in ProductAddonChecker to LOCAL_GMP_SOURCES. r=cpearce OpenH264 is not an EME plugin. So listing it under LOCAL_EME_SOURCES is not appropriate and confusing. Given that both OpenH264 and WideVine plugins are handled by the GMP manager, the name of the local sources list should be named like it. MozReview-Commit-ID: NIXEg2EOm2
toolkit/mozapps/extensions/internal/ProductAddonChecker.jsm
--- a/toolkit/mozapps/extensions/internal/ProductAddonChecker.jsm
+++ b/toolkit/mozapps/extensions/internal/ProductAddonChecker.jsm
@@ -1,17 +1,17 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 "use strict";
 
 /* exported ProductAddonChecker */
 
-const LOCAL_EME_SOURCES = [{
+const LOCAL_GMP_SOURCES = [{
   "id": "gmp-gmpopenh264",
   "src": "chrome://global/content/gmp-sources/openh264.json"
 }, {
   "id": "gmp-widevinecdm",
   "src": "chrome://global/content/gmp-sources/widevinecdm.json"
 }];
 
 var EXPORTED_SYMBOLS = [ "ProductAddonChecker" ];
@@ -228,17 +228,17 @@ function parseXML(document) {
  */
 function downloadLocalConfig() {
 
   if (!GMPPrefs.getBool(GMPPrefs.KEY_UPDATE_ENABLED, true)) {
     logger.info("Updates are disabled via media.gmp-manager.updateEnabled");
     return Promise.resolve({usedFallback: true, gmpAddons: []});
   }
 
-  return Promise.all(LOCAL_EME_SOURCES.map(conf => {
+  return Promise.all(LOCAL_GMP_SOURCES.map(conf => {
     return downloadJSON(conf.src).then(addons => {
 
       let platforms = addons.vendors[conf.id].platforms;
       let target = Services.appinfo.OS + "_" + UpdateUtils.ABI;
       let details = null;
 
       while (!details) {
         if (!(target in platforms)) {