Bug 1187664 - Don't run gst-plugin-scanner through valgrind, it only leads to irrelevant errors. r=njn
☠☠ backed out by a2d31912a7a9 ☠ ☠
authorMike Hommey <mh+mozilla@glandium.org>
Wed, 29 Jul 2015 17:27:05 +0900
changeset 281648 dfc1cb1c26d92739859469392eb794551df40b8e
parent 281647 be94d55627f4e6c57ea34f69556161bd39f001a6
child 281649 79d76aa791fb851b8802aaf83732cd8c441f6683
push id3894
push usermconley@mozilla.com
push dateThu, 30 Jul 2015 00:27:47 +0000
reviewersnjn
bugs1187664
milestone42.0a1
Bug 1187664 - Don't run gst-plugin-scanner through valgrind, it only leads to irrelevant errors. r=njn
build/valgrind/mach_commands.py
--- a/build/valgrind/mach_commands.py
+++ b/build/valgrind/mach_commands.py
@@ -106,16 +106,23 @@ class MachCommands(MachCommandBase):
                 '--smc-check=all-non-file',
                 '--vex-iropt-register-updates=allregs-at-mem-access',
                 '--gen-suppressions=all',
                 '--num-callers=36',
                 '--leak-check=full',
                 '--show-possibly-lost=no',
                 '--track-origins=yes',
                 '--trace-children=yes',
+                # The gstreamer plugin scanner can run as part of executing
+                # firefox, but is an external program. In some weird cases,
+                # valgrind finds errors while executing __libc_freeres when
+                # it runs, but those are not relevant, as it's related to
+                # executing third party code. So don't trace
+                # gst-plugin-scanner.
+                '--trace-children-skip=*/gst-plugin-scanner',
                 '-v',  # Enable verbosity to get the list of used suppressions
             ]
 
             for s in suppressions:
                 valgrind_args.append('--suppressions=' + s)
 
             supps_dir = os.path.join(build_dir, 'valgrind')
             supps_file1 = os.path.join(supps_dir, 'cross-architecture.sup')