Bug 1466231 Part 4: Correct the size of an element in a submitted WPT test, that was only passing due to this bug. draft
authorBrad Werth <bwerth@mozilla.com>
Tue, 12 Jun 2018 11:28:38 -0700
changeset 807792 df2ae5c3a841bad2b5e99e1b6e3b59d792b60d7e
parent 807791 d20f770bbd5fe62a92f552a804b5bffe63c2f871
child 807793 80d718c1edaa5c6193d6eedd56854de320dbea15
push id113218
push userbwerth@mozilla.com
push dateFri, 15 Jun 2018 19:16:11 +0000
bugs1466231
milestone62.0a1
Bug 1466231 Part 4: Correct the size of an element in a submitted WPT test, that was only passing due to this bug. This reftest was submitted by me with an incorrect size for the shape element. It was only passing in Firefox due to a related bug, which is now fixed. The updated size makes this test construct a polygon similar to the one in the shape-outside-polygon-012 test, which was the original intent. MozReview-Commit-ID: CuXe2vTmjS0
layout/reftests/w3c-css/submitted/shapes1/shape-outside-polygon-032.html
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/css/vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-polygon-032.html
--- a/layout/reftests/w3c-css/submitted/shapes1/shape-outside-polygon-032.html
+++ b/layout/reftests/w3c-css/submitted/shapes1/shape-outside-polygon-032.html
@@ -40,18 +40,18 @@
             line-height: 20px;
             width: 240px;
             height: 240px;
             padding: 50px;
             color: green;
         }
         #test-shape {
             float: right;
-            width: 120px;
-            height: 120px;
+            width: 140px;
+            height: 140px;
             margin: 10px;
             border: 10px solid transparent;
             padding: 10px;
             shape-margin: 20px;
             shape-outside: margin-box polygon(20% 20%, 90% 20%, 90% 80%, 50% 80%, 50% 70%, 70% 70%, 70% 40%, 20% 40%);
         }
         .ref-shape {
             position: absolute;
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -556871,17 +556871,17 @@
    "9393c2e2250dfc1bf3ffdd68f2c352890d1e0ee8",
    "reftest"
   ],
   "css/vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-polygon-032-ref.html": [
    "890dd0754f2c985719c75200dd9ef70e8c1abe14",
    "support"
   ],
   "css/vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-polygon-032.html": [
-   "ea8cf594cd61a4aa284342fa895841861af3cd86",
+   "7f64299efa829367c745d317d84c1255b5bb98fd",
    "reftest"
   ],
   "css/vendor-imports/mozilla/mozilla-central-reftests/shapes1/support/Ahem.ttf": [
    "8cdc9e68594fbb6db8c7b4bff643ab2432b51db6",
    "support"
   ],
   "css/vendor-imports/mozilla/mozilla-central-reftests/sync-tests-filter": [
    "3055eafd3bf887f11c0c386419397910ad438d23",
--- a/testing/web-platform/tests/css/vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-polygon-032.html
+++ b/testing/web-platform/tests/css/vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-polygon-032.html
@@ -40,18 +40,18 @@
             line-height: 20px;
             width: 240px;
             height: 240px;
             padding: 50px;
             color: green;
         }
         #test-shape {
             float: right;
-            width: 120px;
-            height: 120px;
+            width: 140px;
+            height: 140px;
             margin: 10px;
             border: 10px solid transparent;
             padding: 10px;
             shape-margin: 20px;
             shape-outside: margin-box polygon(20% 20%, 90% 20%, 90% 80%, 50% 80%, 50% 70%, 70% 70%, 70% 40%, 20% 40%);
         }
         .ref-shape {
             position: absolute;