Bug 1256482 - Disable C4312 to unblock compilation on VS2015; r?jesup draft
authorGregory Szorc <gps@mozilla.com>
Mon, 14 Mar 2016 16:05:06 -0700
changeset 340050 deb1dba5449d15c6b697a02f688d4b19339161c6
parent 340049 a2af8be864806b229ff329ab560a76bc553ef009
child 516132 030db742006b8fe101b214fe2ec971898811a63e
push id12893
push usergszorc@mozilla.com
push dateMon, 14 Mar 2016 23:05:32 +0000
Bug 1256482 - Disable C4312 to unblock compilation on VS2015; r?jesup As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings, of course. Given that the warning is in WebRTC which is third party code, there isn't much we can do about the warning. However, Google is building Chrome with Visual Studio 2015, so I wouldn't be surprised if this were fixed upstream or will be fixed upstream. Then again, we allow warnings when building WebRTC. So perhaps not. MozReview-Commit-ID: G6JP9fkCzfn
--- a/dom/media/webrtc/moz.build
+++ b/dom/media/webrtc/moz.build
@@ -87,10 +87,12 @@ if CONFIG['GNU_CC'] or CONFIG['CLANG_CL'
     CXXFLAGS += [
         '-wd4275', # non dll-interface class used as base for dll-interface class
+        '-wd4312', # This is intended as a temporary hack to support building with VS2015
+                   # 'reinterpret_cast': conversion from 'DWORD' to 'HANDLE' of greater size