Bug 1373193 Part 3: Add a test of insert-after-clone correctness, and remove redundant crashtest. draft
authorBrad Werth <bwerth@mozilla.com>
Mon, 19 Jun 2017 11:36:56 -0700
changeset 597744 dda9d398f3b78f1acca21090fd22d494ba18c41a
parent 597743 13e99229b7deff71e57c2e6aa9b1028fbf2155a0
child 634304 176955e7b1a666083a32e7f1b3896f26199c639e
push id65012
push userbwerth@mozilla.com
push dateTue, 20 Jun 2017 21:58:11 +0000
bugs1373193
milestone56.0a1
Bug 1373193 Part 3: Add a test of insert-after-clone correctness, and remove redundant crashtest. MozReview-Commit-ID: 4pMGZD3i80s
layout/reftests/stylesheet-cloning/importrule.css
layout/reftests/stylesheet-cloning/insert-after-clone.html
layout/reftests/stylesheet-cloning/reftest.list
layout/style/crashtests/645951-1-ref.html
layout/style/crashtests/645951-1.css
layout/style/crashtests/645951-1.html
layout/style/crashtests/crashtests.list
rename from layout/style/crashtests/645951-1.css
rename to layout/reftests/stylesheet-cloning/importrule.css
rename from layout/style/crashtests/645951-1.html
rename to layout/reftests/stylesheet-cloning/insert-after-clone.html
--- a/layout/style/crashtests/645951-1.html
+++ b/layout/reftests/stylesheet-cloning/insert-after-clone.html
@@ -1,11 +1,11 @@
 <!DOCTYPE HTML>
-<title>Test, bug 645951</title>
-<link rel=stylesheet href="645951-1.css">
-<link id="two" rel=stylesheet href="645951-1.css">
+<title>Test insert rule after clone</title>
+<link rel=stylesheet href="importrule.css">
+<link id="two" rel=stylesheet href="importrule.css">
 <body onload="run()">
 <script>
 function run() {
-  document.getElementById("two").sheet.insertRule("p { color: green}", 1);
+  document.getElementById("two").sheet.insertRule("div { color: green}", 1);
 }
 </script>
-<p>Should not crash, and should be green too.</p>
+<div>This should be green</div>
--- a/layout/reftests/stylesheet-cloning/reftest.list
+++ b/layout/reftests/stylesheet-cloning/reftest.list
@@ -1,6 +1,7 @@
 fuzzy-if(webrender,212,342) == counter-style-rule-clone.html glyphs-ref.html # passes trivially
 # because "Dynamic change on @counter-style not yet supported"
 == document-rule-clone.html shouldbegreen-ref.html
 == media-rule-clone.html shouldbegreen-ref.html
+== insert-after-clone.html shouldbegreen-ref.html
 == style-rule-clone.html shouldbegreen-ref.html
 == supports-rule-clone.html shouldbegreen-ref.html
deleted file mode 100644
--- a/layout/style/crashtests/645951-1-ref.html
+++ /dev/null
@@ -1,4 +0,0 @@
-<!DOCTYPE HTML>
-<title>Test, bug 645951</title>
-<body>
-<p style="color: green">Should not crash, and should be green too.</p>
--- a/layout/style/crashtests/crashtests.list
+++ b/layout/style/crashtests/crashtests.list
@@ -70,17 +70,16 @@ load 592698-1.html
 load 601437-1.html
 load 601439-1.html
 load 605689-1.html
 load 611922-1.html
 load 621596-1.html
 load 622314-1.xhtml
 load 637242.xhtml
 load 645142.html
-fails-if(stylo) == 645951-1.html 645951-1-ref.html # bug 1367213
 load 652976-1.svg
 load 665209-1.html
 load 671799-1.html
 load 671799-2.html
 load 690990-1.html
 load 696188-1.html
 load 696869-1.html
 load 700116.html