Bug 1402426 - removing the requirement to sign addons from talos and run from source. reland as this was partially reverted in a mozreview rebase. r=me
authorJoel Maher <jmaher@mozilla.com>
Mon, 09 Oct 2017 08:42:51 -0400
changeset 676884 da9caebfed4112f7cf84a1358c3b9ac461e5688d
parent 676883 e92d092fdacc83b14dd65a4ec3c9cada16406ce6
child 676885 6b7fbf00410efd3ee5af310eeb0dcfdebb729244
push id83658
push userbmo:tchiovoloni@mozilla.com
push dateMon, 09 Oct 2017 20:19:32 +0000
reviewersme
bugs1402426
milestone58.0a1
Bug 1402426 - removing the requirement to sign addons from talos and run from source. reland as this was partially reverted in a mozreview rebase. r=me
testing/talos/talos/ffsetup.py
testing/talos/talos/run_tests.py
--- a/testing/talos/talos/ffsetup.py
+++ b/testing/talos/talos/ffsetup.py
@@ -88,20 +88,16 @@ class FFSetup(object):
             if type(value) is str:
                 value = utils.interpolate(value, webserver=webserver)
                 preferences[name] = value
 
         extensions = self.browser_config['extensions'][:]
         if self.test_config.get('extensions'):
             extensions.append(self.test_config['extensions'])
 
-        if self.browser_config['develop'] or \
-           'try' in str.lower(self.browser_config['branch_name']):
-            extensions = [os.path.dirname(i) for i in extensions]
-
         # downloading a profile instead of using the empty one
         if self.test_config['profile'] is not None:
             path = heavy.download_profile(self.test_config['profile'])
             self.test_config['profile_path'] = path
 
         profile = Profile.clone(
             os.path.normpath(self.test_config['profile_path']),
             self.profile_dir,
--- a/testing/talos/talos/run_tests.py
+++ b/testing/talos/talos/run_tests.py
@@ -113,22 +113,16 @@ def run_tests(config, browser_config):
         test['profile'] = config.get('profile')
 
     # pass --no-remote to firefox launch, if --develop is specified
     # we do that to allow locally the user to have another running firefox
     # instance
     if browser_config['develop']:
         browser_config['extra_args'] = '--no-remote'
 
-    # with addon signing for production talos, we want to develop without it
-    if browser_config['develop'] or 'try' in str.lower(browser_config['branch_name']):
-        browser_config['preferences']['xpinstall.signatures.required'] = False
-
-    browser_config['preferences']['extensions.allow-non-mpc-extensions'] = True
-
     # if using firstNonBlankPaint, must turn on pref for it
     if test.get('fnbpaint', False):
         LOG.info("Using firstNonBlankPaint, so turning on pref for it")
         browser_config['preferences']['dom.performance.time_to_non_blank_paint.enabled'] = True
 
     # set defaults
     testdate = config.get('testdate', '')