Bug 1334126 - Fix "Screenshot icon beside Screenshot Behavior label looks inconsistent". r=ntim.bugs
authorJaideep Bhoosreddy <jaideepb@buffalo.edu>
Mon, 30 Jan 2017 14:00:00 +0100
changeset 468846 da8fb81b403839897571cb6943edd1885957a1a2
parent 468845 85d33b74434a76f5d49c5c88482cc94014c6e6c2
child 468847 58e48aa02dcee851a1bbbd5bb30360b1bb8f2a7a
push id43551
push userbmo:kgilbert@mozilla.com
push dateTue, 31 Jan 2017 23:27:06 +0000
reviewersntim.bugs
bugs1334126
milestone54.0a1
Bug 1334126 - Fix "Screenshot icon beside Screenshot Behavior label looks inconsistent". r=ntim.bugs
devtools/client/framework/options-panel.css
devtools/client/framework/toolbox-options.xhtml
--- a/devtools/client/framework/options-panel.css
+++ b/devtools/client/framework/options-panel.css
@@ -105,12 +105,17 @@
 #devtools-sourceeditor-keybinding-select {
   min-width: 130px;
 }
 
 #devtools-sourceeditor-tabsize-select {
   min-width: 80px;
 }
 
+#screenshot-icon {
+  vertical-align: middle;
+  min-width: 0;
+  padding: 5px;
+}
+
 #screenshot-icon::before {
   background-image: url(chrome://devtools/skin/images/command-screenshot.svg);
-  margin-inline-start: 5px;
 }
--- a/devtools/client/framework/toolbox-options.xhtml
+++ b/devtools/client/framework/toolbox-options.xhtml
@@ -105,17 +105,17 @@
           <input type="checkbox"
                  data-pref="devtools.styleeditor.autocompletion-enabled"/>
           <span>&options.stylesheetAutocompletion.label;</span>
         </label>
       </fieldset>
 
       <fieldset id="screenshot-options" class="options-groupbox">
         <legend>&options.screenshot.label;
-          <span id="screenshot-icon" class="devtools-button"></span>
+          <button id="screenshot-icon" disabled="true" class="devtools-button"></button>
         </legend>
         <label title="&options.screenshot.clipboard.tooltip;">
           <input type="checkbox"
                  id="devtools-screenshot-clipboard"
                  data-pref="devtools.screenshot.clipboard.enabled"/>
           <span>&options.screenshot.clipboard.label;</span>
         </label>
         <label title="&options.screenshot.audio.tooltip;">