reviewboard: add test for pushing to submitted review request; r=smacleod
authorGregory Szorc <gps@mozilla.com>
Tue, 12 Jan 2016 14:01:20 -0800
changeset 362096 da72429dca189827af3b3135210314617bcff287
parent 362095 05e92374b355c8d288c122856a67c7aef9f1b4f7
child 362097 4521cdc7a1d79470c90f3a912d0fb9682d3810a1
push id16998
push userrwood@mozilla.com
push dateMon, 02 May 2016 19:42:03 +0000
reviewerssmacleod
reviewboard: add test for pushing to submitted review request; r=smacleod We swallow output because it currently spews an exception stack, which is a bug already on file.
hgext/reviewboard/tests/test-review-request-closed-submitted.t
--- a/hgext/reviewboard/tests/test-review-request-closed-submitted.t
+++ b/hgext/reviewboard/tests/test-review-request-closed-submitted.t
@@ -162,16 +162,25 @@ Child review request with ID 2 should be
     - +++ b/foo
     - '@@ -1,1 +1,1 @@'
     - -foo1
     - +foo2
     - ''
   approved: false
   approval_failure: A suitable reviewer has not given a "Ship It!"
 
+Submitting against a published review request results in error
+TODO Fix the error output (bug 1169664)
+
+  $ echo foo3 > foo
+  $ hg commit -m 'Bug 1 - Foo 3'
+  $ hg push > /dev/null
+  abort: unexpected response: empty string
+  [255]
+
 Re-opening the parent review request should re-open all of the children.
 
   $ rbmanage reopen 1
 
 Squashed review request with ID 1 should be re-opened...
 
   $ rbmanage dumpreview 1
   id: 1