Bug 1433708: Part 2 - Fix ExtensionsUI innerHTML sanitization. r=aswan
authorKris Maglione <maglione.k@gmail.com>
Fri, 26 Jan 2018 11:06:35 -0800
changeset 748676 d99263bcef5dea39a79b8664cc0b20df9954dfed
parent 748675 dfbd7bb8567331d80c5a521641817ae14e757d8a
child 748677 15bc3960cd39e5c53bd53d807dad243c319d16b5
push id97228
push usersfraser@mozilla.com
push dateTue, 30 Jan 2018 10:21:04 +0000
reviewersaswan
bugs1433708
milestone60.0a1
Bug 1433708: Part 2 - Fix ExtensionsUI innerHTML sanitization. r=aswan MozReview-Commit-ID: B8Lzqx56fBi
browser/modules/ExtensionsUI.jsm
--- a/browser/modules/ExtensionsUI.jsm
+++ b/browser/modules/ExtensionsUI.jsm
@@ -424,20 +424,20 @@ this.ExtensionsUI = {
         hideClose: true,
         timeout: Date.now() + 30000,
         popupIconURL: icon,
         eventCallback(topic) {
           if (topic == "showing") {
             let doc = this.browser.ownerDocument;
         // eslint-disable-next-line no-unsanitized/property
             doc.getElementById("addon-installed-notification-header")
-               .innerHTML = msg1;
+               .unsafeSetInnerHTML(msg1);
             // eslint-disable-next-line no-unsanitized/property
             doc.getElementById("addon-installed-notification-message")
-               .innerHTML = msg2;
+               .unsafeSetInnerHTML(msg2);
           } else if (topic == "dismissed") {
             resolve();
           }
         }
       };
 
       popups.show(target, "addon-installed", "", "addons-notification-icon",
                   action, null, options);