Bug 1406631: Make input[type=color] rules consistent on Android. r?xidorn draft
authorEmilio Cobos Álvarez <emilio@crisal.io>
Tue, 10 Oct 2017 10:48:33 +0200
changeset 677145 d96d7fa46faf11311055d535925a8ec9268631eb
parent 677144 35ce9f78912b03fe1c1fbc9364e6750736d010dc
child 677146 337a9864c10b68e69fd34b3d8f8404573bc06c09
child 677292 1cb191e1f046e77b958d5b9aad1fc4120f17468d
push id83715
push userbmo:emilio@crisal.io
push dateTue, 10 Oct 2017 09:13:50 +0000
reviewersxidorn
bugs1406631
milestone58.0a1
Bug 1406631: Make input[type=color] rules consistent on Android. r?xidorn Before this patch, the :-moz-system-metric pseudo-class made the input[type="color"] rules more specific than this rule in content.css: * > input:not(:-moz-any([type="image"], [type="checkbox"], [type="radio"])) After removing it, this is not the case. This seems like an accident, so let's make input[type="color"] consistent with the rest of the buttons just the same way as in forms.css. MozReview-Commit-ID: 7oPsxMBDdED
mobile/android/themes/geckoview/content.css
--- a/mobile/android/themes/geckoview/content.css
+++ b/mobile/android/themes/geckoview/content.css
@@ -162,16 +162,17 @@ textarea {
   padding-inline-end: 1px;
   padding-block-start: 2px;
   padding-block-end: 2px;
 }
 
 input[type="button"],
 input[type="submit"],
 input[type="reset"],
+input[type="color"],
 button {
   border-width: 1px;
   padding-inline-start: 7px;
   padding-inline-end: 7px;
   padding-block-start: 0;
   padding-block-end: 0;
 }
 
@@ -201,16 +202,17 @@ input[type="file"]:focus > input[type="t
   border-style: solid;
   border-color: var(--form_border);
   background-color: var(--form_background);
 }
 
 select:not([size]):not([multiple]):focus,
 select[size="0"]:focus,
 select[size="1"]:focus,
+input[type="color"]:focus,
 input[type="button"]:focus,
 input[type="submit"]:focus,
 input[type="reset"]:focus,
 button:focus {
   outline: 0px !important;
   border-style: solid;
   border-color: var(--form_border);
   background-color: var(--form_background);
@@ -242,16 +244,18 @@ select[size="1"]:disabled {
 }
 
 input[type="button"]:disabled,
 input[type="button"]:disabled:active,
 input[type="submit"]:disabled,
 input[type="submit"]:disabled:active,
 input[type="reset"]:disabled,
 input[type="reset"]:disabled:active,
+input[type="color"]:disabled,
+input[type="color"]:disabled:active,
 button:disabled,
 button:disabled:active {
   padding-inline-start: 7px;
   padding-inline-end: 7px;
   padding-block-start: 0;
   padding-block-end: 0;
   background-color: var(--form_background_disabled);
 }