Bug 1234199 - fix mobile promo links in synced tabs menu. r=adw
authorMark Hammond <mhammond@skippinet.com.au>
Wed, 23 Dec 2015 08:57:46 +1100
changeset 317160 d7a2a9cfdeb890fb9bbff3e20c064875e13b929d
parent 317159 91c2a2502721dfcaf032cbd0c419d3e789f334f6
child 317161 645cb0f2d2836e5daddff06665bbd306a8b9093d
push id8657
push usermichael.l.comella@gmail.com
push dateTue, 22 Dec 2015 22:31:59 +0000
reviewersadw
bugs1234199
milestone46.0a1
Bug 1234199 - fix mobile promo links in synced tabs menu. r=adw
browser/components/customizableui/CustomizableWidgets.jsm
--- a/browser/components/customizableui/CustomizableWidgets.jsm
+++ b/browser/components/customizableui/CustomizableWidgets.jsm
@@ -312,17 +312,17 @@ const CustomizableWidgets = [
       obnode.setAttribute("attribute", "syncstatus");
       aNode.appendChild(obnode);
 
       // A somewhat complicated dance to format the mobilepromo label.
       let bundle = doc.getElementById("bundle_browser");
       let formatArgs = ["android", "ios"].map(os => {
         let link = doc.createElement("label");
         link.textContent = bundle.getString(`appMenuRemoteTabs.mobilePromo.${os}`)
-        link.href = Services.prefs.getCharPref(`identity.mobilepromo.${os}`) + "synced-tabs";
+        link.setAttribute("href", Services.prefs.getCharPref(`identity.mobilepromo.${os}`) + "synced-tabs");
         link.className = "text-link remotetabs-promo-link";
         return link.outerHTML;
       });
       // Put it all together...
       let contents = bundle.getFormattedString("appMenuRemoteTabs.mobilePromo", formatArgs);
       doc.getElementById("PanelUI-remotetabs-mobile-promo").innerHTML = contents;
     },
     onViewShowing(aEvent) {