Bug 1422915 - Be explicit about remote-active data when shutting down. r=whimboo
☠☠ backed out by 0a040f4441d0 ☠ ☠
authorAndreas Tolfsen <ato@sny.no>
Mon, 04 Dec 2017 18:55:42 +0000
changeset 708674 d61481e31a93819cb54e07525294c8b42b8f7e90
parent 708673 a30ad544bf0feae8395af0eb597a929befdcb679
child 708675 c8209a5b165959a0410a24751065ad604c5933bc
push id92403
push userVYV03354@nifty.ne.jp
push dateWed, 06 Dec 2017 22:18:41 +0000
reviewerswhimboo
bugs1422915
milestone59.0a1
Bug 1422915 - Be explicit about remote-active data when shutting down. r=whimboo When Marionette starts and shuts down it emits the remote-active system notification. On starting the data is set to true (a boolean), but on shutdown it is left undefined which defaults to null. We should use false (boolean) explicitly. MozReview-Commit-ID: Er0Wn2pZrOi
testing/marionette/server.js
--- a/testing/marionette/server.js
+++ b/testing/marionette/server.js
@@ -383,17 +383,17 @@ server.TCPListener = class {
       logger.debug(`Resetting recommended pref ${k}`);
       Preferences.reset(k);
     }
     this.alteredPrefs.clear();
 
     // Shutdown server socket, and no longer listen for new connections
     this.acceptConnections = false;
 
-    Services.obs.notifyObservers(this, NOTIFY_RUNNING);
+    Services.obs.notifyObservers(this, NOTIFY_RUNNING, false);
     this.alive = false;
   }
 
   onSocketAccepted(serverSocket, clientSocket) {
     let input = clientSocket.openInputStream(0, 0, 0);
     let output = clientSocket.openOutputStream(0, 0, 0);
     let transport = new DebuggerTransport(input, output);