Bug 1402311 - use fill-opacity instead of hardcoded fill colour for disabled overflow button in customize mode, r?mikedeboer draft
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Tue, 26 Sep 2017 15:17:26 +0100
changeset 670520 d1af4c6d90d5076b654cb51d12f8ff7fc5ced3a0
parent 669742 5f3f19824efa14cc6db546baf59c54a0fc15ddc9
child 733251 eceebbff9199f12382a3995fe3a5c64335a358f3
push id81649
push usergijskruitbosch@gmail.com
push dateTue, 26 Sep 2017 14:17:23 +0000
reviewersmikedeboer
bugs1402311
milestone58.0a1
Bug 1402311 - use fill-opacity instead of hardcoded fill colour for disabled overflow button in customize mode, r?mikedeboer MozReview-Commit-ID: JKeA5ZNAh5J
browser/themes/shared/customizableui/customizeMode.inc.css
--- a/browser/themes/shared/customizableui/customizeMode.inc.css
+++ b/browser/themes/shared/customizableui/customizeMode.inc.css
@@ -441,25 +441,20 @@ toolbarpaletteitem[place=toolbar] > tool
 }
 
 #customization-panelWrapper > .panel-arrowbox {
   position: relative;
   height: 10px;
   margin-bottom: -1px;
 }
 
-/* The overflow button icon _looks_ disabled, but is also shown as [open]. */
-#nav-bar[customizing] > .overflow-button {
-  /* This color is the hard-coded #4c4c4c at 40% opacity as found in toolbarbutton-icons.inc.css */
-  fill: hsla(0,0%,30%,.4);
-}
-
 #nav-bar[customizing] > .overflow-button > .toolbarbutton-icon {
   background-color: var(--toolbarbutton-active-background);
   opacity: 1;
+  fill-opacity: 0.4;
 }
 
 #customization-panelWrapper > .panel-arrowbox > .panel-arrow[side="top"] {
 %ifdef XP_MACOSX
   list-style-image: var(--panel-arrow-image-vertical,
                         url("chrome://global/skin/arrow/panelarrow-vertical.png"));
   /* The OS X image is 2px narrower than the windows/linux one.
    * Add padding to compensate: */