Bug 1075232 - Record which suggestion of the search screen was tapped in telemetry. r=mfinkle
--- a/mobile/android/base/home/SearchEngineRow.java
+++ b/mobile/android/base/home/SearchEngineRow.java
@@ -84,17 +84,18 @@ class SearchEngineRow extends AnimatedHe
Telemetry.sendUIEvent(TelemetryContract.Event.LOAD_URL, TelemetryContract.Method.SUGGESTION, "url");
mUrlOpenListener.onUrlOpen(suggestion, EnumSet.noneOf(OnUrlOpenListener.Flags.class));
}
} else if (mSearchListener != null) {
if (v == mUserEnteredView) {
Telemetry.sendUIEvent(TelemetryContract.Event.LOAD_URL, TelemetryContract.Method.SUGGESTION, "user");
} else {
- Telemetry.sendUIEvent(TelemetryContract.Event.LOAD_URL, TelemetryContract.Method.SUGGESTION, "engine");
+ final String extras = "engine." + (String) v.getTag();
+ Telemetry.sendUIEvent(TelemetryContract.Event.LOAD_URL, TelemetryContract.Method.SUGGESTION, extras);
}
mSearchListener.onSearch(mSearchEngine, suggestion);
}
}
};
mLongClickListener = new OnLongClickListener() {
@Override
@@ -193,16 +194,19 @@ class SearchEngineRow extends AnimatedHe
suggestionItem = mSuggestionView.getChildAt(suggestionCounter + 1);
suggestionItem.setVisibility(View.VISIBLE);
} else {
suggestionItem = mInflater.inflate(R.layout.suggestion_item, null);
suggestionItem.setOnClickListener(mClickListener);
suggestionItem.setOnLongClickListener(mLongClickListener);
+ // Store the position of the suggestion for telemetry.
+ suggestionItem.setTag(String.valueOf(suggestionCounter));
+
final ImageView magnifier =
(ImageView) suggestionItem.findViewById(R.id.suggestion_magnifier);
magnifier.setVisibility(View.GONE);
mSuggestionView.addView(suggestionItem);
}
setSuggestionOnView(suggestionItem, suggestion);