Bug 1254395 - push to cdn for non release promotion case doesn't use credentials, r?nthomas draft
authorJordan Lund <jlund@mozilla.com>
Mon, 07 Mar 2016 18:52:51 -0800
changeset 337993 cfed5bb4e3f66224e5f2c7ca5ee4650f8be5ede2
parent 337992 bbaf0ef3deea8b2989eb5a23be9861cf3e08720f
child 515702 156489a0c99d8802ba92fbb9d7eee1c1c98044c6
push id12404
push userjlund@mozilla.com
push dateTue, 08 Mar 2016 02:54:16 +0000
reviewersnthomas
bugs1254395
milestone46.0
Bug 1254395 - push to cdn for non release promotion case doesn't use credentials, r?nthomas MozReview-Commit-ID: AYbMZVNxwo
testing/mozharness/scripts/release/push-candidate-to-releases.py
--- a/testing/mozharness/scripts/release/push-candidate-to-releases.py
+++ b/testing/mozharness/scripts/release/push-candidate-to-releases.py
@@ -72,17 +72,17 @@ class ReleasePusher(BaseScript, Virtuale
 
         # validate aws credentials
         if not (all(aws_creds) or self.config.get('credentials')):
             self.fatal("aws creds not defined. please add them to your config or env.")
         if any(aws_creds) and self.config.get('credentials'):
             self.fatal("aws creds found in env and self.config. please declare in one place only.")
 
         # set aws credentials
-        if aws_creds:
+        if all(aws_creds):
             self.aws_key_id, self.aws_secret_key = aws_creds
         else:  # use
             self.aws_key_id, self.aws_secret_key = None, None
             # set the env var for boto to read our special config file
             # rather than anything else we have at ~/.boto
             os.environ["BOTO_CONFIG"] = os.path.abspath(self.config["credentials"])
 
     def _pre_config_lock(self, rw_config):