Bug 1257325 - Disable C4838 to unblock compilation on VS2015; r?rbarnes draft
authorGregory Szorc <gps@mozilla.com>
Wed, 16 Mar 2016 14:17:30 -0700
changeset 341320 cf96aa6390d1570d087bbcf2e15729a640b1b1a3
parent 341319 556502c7d952b7d64f98a106d1aced4aff0469dd
child 516380 f440f459659c9950c151e310eca9c10bfdc06030
push id13188
push usergszorc@mozilla.com
push dateWed, 16 Mar 2016 21:17:52 +0000
reviewersrbarnes
bugs1257325
milestone48.0a1
Bug 1257325 - Disable C4838 to unblock compilation on VS2015; r?rbarnes As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists on fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. MozReview-Commit-ID: 6UrAbeEAxLc
dom/crypto/moz.build
--- a/dom/crypto/moz.build
+++ b/dom/crypto/moz.build
@@ -26,9 +26,16 @@ include('/ipc/chromium/chromium-config.m
 FINAL_LIBRARY = 'xul'
 
 LOCAL_INCLUDES += [
     '/security/manager/ssl',
     '/security/pkix/include',
     '/xpcom/build',
 ]
 
+if CONFIG['_MSC_VER']:
+    # This is intended as a temporary workaround to enable building warning
+    # free on Visual Studio 2015.
+    # conversion from 'nsTArray_base<Alloc,nsTArray_CopyChooser<E>::Type>::size_type' to
+    # 'CK_ULONG' requires a narrowing conversion
+    CXXFLAGS += ['-wd4838']
+
 MOCHITEST_MANIFESTS += ['test/mochitest.ini']