Bug 1274727 - Use toString method for search engine identifiers. r=bnicholson
authorMichael Comella <michael.l.comella@gmail.com>
Mon, 23 May 2016 15:26:26 -0700
changeset 370274 cf8073f1db3b9bcee2c2dc208ef22993c3f25406
parent 370273 30846a1ffc2b3b08c5a3e3f2110d4ee7eae1ac6f
child 370275 021ff359274b008d3d9a4c74ed07a67f965a75c2
push id19026
push userbobowencode@gmail.com
push dateTue, 24 May 2016 12:34:53 +0000
reviewersbnicholson
bugs1274727
milestone49.0a1
Bug 1274727 - Use toString method for search engine identifiers. r=bnicholson These values are what are actually used UI telemetry (perhaps because the enums were added after the strings?). They're also a little less obnoxious than the enum names. MozReview-Commit-ID: K5i2Hr4DR4J
mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
--- a/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
+++ b/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
@@ -2434,17 +2434,17 @@ public class BrowserApp extends GeckoApp
      *
      * @param where where the search was started from
      */
     private static void recordSearch(@NonNull final SharedPreferences prefs, @NonNull final String engineIdentifier,
             @NonNull final TelemetryContract.Method where) {
         // We could include the engine identifier as an extra but we'll
         // just capture that with core ping telemetry (bug 1253319).
         Telemetry.sendUIEvent(TelemetryContract.Event.SEARCH, where);
-        SearchCountMeasurements.incrementSearch(prefs, engineIdentifier, where.name());
+        SearchCountMeasurements.incrementSearch(prefs, engineIdentifier, where.toString());
     }
 
     /**
      * Store search query in SearchHistoryProvider.
      *
      * @param query
      *        a search query to store. We won't store empty queries.
      */