Bug 1296614 - Firefox-ui-functional tests should be also run for ASAN builds r=dustin
authorHenrik Skupin <mail@hskupin.info>
Mon, 22 Aug 2016 13:47:17 +0200
changeset 407028 cecb866cbec6fa2a74aaebdaf0b21175a12732a9
parent 407027 fe6f06ab94329afe1bd9aec3333757c89bfdd3c6
child 407029 7f33fad15f7c48a7544f2045179f36bfee81a9be
push id27893
push userbmo:gasolin@mozilla.com
push dateTue, 30 Aug 2016 03:41:38 +0000
reviewersdustin
bugs1296614
milestone51.0a1
Bug 1296614 - Firefox-ui-functional tests should be also run for ASAN builds r=dustin MozReview-Commit-ID: A4EILsuV5qH
taskcluster/ci/desktop-test/test-sets.yml
testing/mozharness/configs/firefox_ui_tests/taskcluster.py
testing/mozharness/mozharness/mozilla/testing/firefox_ui_tests.py
--- a/taskcluster/ci/desktop-test/test-sets.yml
+++ b/taskcluster/ci/desktop-test/test-sets.yml
@@ -33,16 +33,18 @@ all-tests:
     - reftest-no-accel
     - web-platform-tests
     - web-platform-tests-reftests
     - xpcshell
 
 asan-tests:
     - cppunit
     - crashtest
+    - firefox-ui-functional-local
+    - firefox-ui-functional-remote
     - gtest
     - jittests
     - jsreftest
     - marionette
     - mochitest
     - mochitest-browser-chrome
     - mochitest-chrome
     - mochitest-clipboard
--- a/testing/mozharness/configs/firefox_ui_tests/taskcluster.py
+++ b/testing/mozharness/configs/firefox_ui_tests/taskcluster.py
@@ -2,13 +2,10 @@
 
 config = {
     "find_links": [
         "http://pypi.pub.build.mozilla.org/pub",
     ],
 
     "pip_index": False,
 
-    "download_symbols": "ondemand",
-    "download_minidump_stackwalk": True,
-
     "tooltool_cache": "/builds/tooltool_cache",
 }
--- a/testing/mozharness/mozharness/mozilla/testing/firefox_ui_tests.py
+++ b/testing/mozharness/mozharness/mozilla/testing/firefox_ui_tests.py
@@ -17,51 +17,42 @@ from mozharness.mozilla.testing.testbase
     TestingMixin,
     testing_config_options,
 )
 from mozharness.mozilla.vcstools import VCSToolsScript
 
 
 # General command line arguments for Firefox ui tests
 firefox_ui_tests_config_options = [
+    [["--allow-software-gl-layers"], {
+        "action": "store_true",
+        "dest": "allow_software_gl_layers",
+        "default": False,
+        "help": "Permits a software GL implementation (such as LLVMPipe) to use the GL compositor.",
+    }],
     [['--dry-run'], {
         'dest': 'dry_run',
         'default': False,
         'help': 'Only show what was going to be tested.',
     }],
     [["--e10s"], {
         'dest': 'e10s',
         'action': 'store_true',
         'default': False,
         'help': 'Enable multi-process (e10s) mode when running tests.',
     }],
-    [['--firefox-ui-branch'], {
-        'dest': 'firefox_ui_branch',
-        'help': 'which branch to use for firefox_ui_tests',
-    }],
-    [['--firefox-ui-repo'], {
-        'dest': 'firefox_ui_repo',
-        'default': 'https://github.com/mozilla/firefox-ui-tests.git',
-        'help': 'which firefox_ui_tests repo to use',
-    }],
     [['--symbols-path=SYMBOLS_PATH'], {
         'dest': 'symbols_path',
         'help': 'absolute path to directory containing breakpad '
                 'symbols, or the url of a zip file containing symbols.',
     }],
     [['--tag=TAG'], {
         'dest': 'tag',
         'help': 'Subset of tests to run (local, remote).',
     }],
-    [["--allow-software-gl-layers"], {
-        "action": "store_true",
-        "dest": "allow_software_gl_layers",
-        "default": False,
-        "help": "Permits a software GL implementation (such as LLVMPipe) to use the GL compositor.",
-    }],
 ] + copy.deepcopy(testing_config_options)
 
 # Command line arguments for update tests
 firefox_ui_update_harness_config_options = [
     [['--update-allow-mar-channel'], {
         'dest': 'update_allow_mar_channel',
         'help': 'Additional MAR channel to be allowed for updates, e.g. '
                 '"firefox-mozilla-beta" for updating a release build to '