Bug 1312642 - PlacesSyncUtils should pass SOURCE_SYNC to PlacesUtils.bookmarks.reorder. r?kitcambridge draft
authorMark Hammond <mhammond@skippinet.com.au>
Tue, 25 Oct 2016 13:47:33 +1100
changeset 429024 ce4b29e65e8d7d7fd01e55b6932806a955ce6552
parent 429023 b18e4a29ee61ca92a68e1ae9498115daf07090ea
child 534888 4830b8366d2480a4a03d1ed6cb88ae73a01215cd
push id33474
push userbmo:markh@mozilla.com
push dateTue, 25 Oct 2016 02:48:00 +0000
reviewerskitcambridge
bugs1312642
milestone52.0a1
Bug 1312642 - PlacesSyncUtils should pass SOURCE_SYNC to PlacesUtils.bookmarks.reorder. r?kitcambridge MozReview-Commit-ID: 4EsnU7LSWDG
toolkit/components/places/PlacesSyncUtils.jsm
--- a/toolkit/components/places/PlacesSyncUtils.jsm
+++ b/toolkit/components/places/PlacesSyncUtils.jsm
@@ -123,17 +123,18 @@ const BookmarkSyncUtils = PlacesSyncUtil
     }
     let parentGuid = BookmarkSyncUtils.syncIdToGuid(parentSyncId);
     if (parentGuid == PlacesUtils.bookmarks.rootGuid) {
       // Reordering roots doesn't make sense, but Sync will do this on the
       // first sync.
       return;
     }
     let orderedChildrenGuids = childSyncIds.map(BookmarkSyncUtils.syncIdToGuid);
-    return PlacesUtils.bookmarks.reorder(parentGuid, orderedChildrenGuids);
+    return PlacesUtils.bookmarks.reorder(parentGuid, orderedChildrenGuids,
+                                         { source: SOURCE_SYNC });
   }),
 
   /**
    * Removes an item from the database. Options are passed through to
    * PlacesUtils.bookmarks.remove.
    */
   remove: Task.async(function* (syncId, options = {}) {
     let guid = BookmarkSyncUtils.syncIdToGuid(syncId);