Bug 1251893 - Change TC Linux64 debug jobs to always download symbols. r=ted
authorArmen Zambrano Gasparnian <armenzg@mozilla.com>
Thu, 14 Apr 2016 08:47:09 -0400
changeset 354479 cc6534601ad80c04c260493112e9a8d621c304ad
parent 354478 ab5be7357e5372c76c3510300de99a89dfbc1020
child 354480 93090fa3065335c9f830e9c70cbfbbc2f40fd979
child 354624 e0d5bf97a1821bd08b45415bc701b3e7c56bd0a4
push id16088
push usergkruglov@mozilla.com
push dateWed, 20 Apr 2016 23:45:23 +0000
reviewersted
bugs1251893
milestone48.0a1
Bug 1251893 - Change TC Linux64 debug jobs to always download symbols. r=ted Debug test jobs are expected to cause asserts and we need to have symbols on disk to get proper allocation stacks. The OutputParser requires the symbols to be on disk upon contrustcion of the object [1][2]. [1] https://dxr.mozilla.org/mozilla-central/rev/5e0140b6d11821e0c2a2de25bc5431783f03380a/testing/mochitest/runtests.py#2484 [2] https://dxr.mozilla.org/mozilla-central/rev/5e0140b6d11821e0c2a2de25bc5431783f03380a/testing/mozbase/mozrunner/mozrunner/utils.py#266 MozReview-Commit-ID: FpI5iDNHI32
testing/taskcluster/tasks/tests/fx_desktop_unittest.yml
testing/taskcluster/tasks/tests/fx_linux64_cppunit.yml
testing/taskcluster/tasks/tests/fx_linux64_gtest.yml
testing/taskcluster/tasks/tests/fx_linux64_marionette.yml
testing/taskcluster/tasks/tests/fx_linux64_marionette_e10s.yml
testing/taskcluster/tasks/tests/fx_linux64_web_platform_tests.yml
testing/taskcluster/tasks/tests/fx_linux64_web_platform_tests_e10s.yml
testing/taskcluster/tasks/tests/fx_linux64_web_platform_tests_reftests.yml
testing/taskcluster/tasks/tests/fx_linux64_web_platform_tests_reftests_e10s.yml
--- a/testing/taskcluster/tasks/tests/fx_desktop_unittest.yml
+++ b/testing/taskcluster/tasks/tests/fx_desktop_unittest.yml
@@ -4,17 +4,17 @@
 task:
   payload:
     command:
       - bash
       - /home/worker/bin/test.sh
       - --no-read-buildbot-config
       - --installer-url={{build_url}}
       - --test-packages-url={{test_packages_url}}
-      - --download-symbols=ondemand
+      - --download-symbols=true # This value is to be ondemand for opt jobs
       - --{{suite}}-suite={{flavor}}
       - --total-chunk={{total_chunks}}
       - --this-chunk={{chunk}}
     env:
         MOZHARNESS_SCRIPT: 'mozharness/scripts/desktop_unittest.py'
         # TODO move linux_unittest.py to a platform specific config
         MOZHARNESS_CONFIG: >
           mozharness/configs/unittests/linux_unittest.py
--- a/testing/taskcluster/tasks/tests/fx_linux64_cppunit.yml
+++ b/testing/taskcluster/tasks/tests/fx_linux64_cppunit.yml
@@ -2,17 +2,17 @@
 $inherits:
   from: 'tasks/tests/fx_desktop_generic.yml'
 task:
   payload:
     command:
       - --no-read-buildbot-config
       - --installer-url={{build_url}}
       - --test-packages-url={{test_packages_url}}
-      - --download-symbols=ondemand
+      - --download-symbols=true # This value is to be ondemand for opt jobs
       - --cppunittest-suite=cppunittest
     env:
         MOZHARNESS_SCRIPT: 'mozharness/scripts/desktop_unittest.py'
         MOZHARNESS_CONFIG: >
           mozharness/configs/unittests/linux_unittest.py
           mozharness/configs/remove_executables.py
   metadata:
     name: '[TC] Linux64 cppunit'
--- a/testing/taskcluster/tasks/tests/fx_linux64_gtest.yml
+++ b/testing/taskcluster/tasks/tests/fx_linux64_gtest.yml
@@ -3,17 +3,17 @@
   from: 'tasks/tests/fx_desktop_generic.yml'
 task:
   workerType: desktop-test-xlarge
   payload:
     command:
       - --no-read-buildbot-config
       - --installer-url={{build_url}}
       - --test-packages-url={{test_packages_url}}
-      - --download-symbols=ondemand
+      - --download-symbols=true # This value is to be ondemand for opt jobs
       - --{{suite}}-suite={{flavor}}
     env:
         MOZHARNESS_SCRIPT: 'mozharness/scripts/desktop_unittest.py'
         MOZHARNESS_CONFIG: >
           mozharness/configs/unittests/linux_unittest.py
           mozharness/configs/remove_executables.py
   metadata:
     name: '[TC] Linux64 gtest'
--- a/testing/taskcluster/tasks/tests/fx_linux64_marionette.yml
+++ b/testing/taskcluster/tasks/tests/fx_linux64_marionette.yml
@@ -2,17 +2,17 @@
 $inherits:
   from: 'tasks/tests/fx_desktop_generic.yml'
 task:
   payload:
     command:
       - --no-read-buildbot-config
       - --installer-url={{build_url}}
       - --test-packages-url={{test_packages_url}}
-      - --download-symbols=ondemand
+      - --download-symbols=true # This value is to be ondemand for opt jobs
     env:
         MOZHARNESS_SCRIPT: 'mozharness/scripts/marionette.py'
         MOZHARNESS_CONFIG: >
           mozharness/configs/marionette/prod_config.py
           mozharness/configs/remove_executables.py
     maxRunTime: 5400
   metadata:
     name: '[TC] Linux64 marionette'
--- a/testing/taskcluster/tasks/tests/fx_linux64_marionette_e10s.yml
+++ b/testing/taskcluster/tasks/tests/fx_linux64_marionette_e10s.yml
@@ -2,17 +2,17 @@
 $inherits:
   from: 'tasks/tests/fx_desktop_generic.yml'
 task:
   payload:
     command:
       - --no-read-buildbot-config
       - --installer-url={{build_url}}
       - --test-packages-url={{test_packages_url}}
-      - --download-symbols=ondemand
+      - --download-symbols=true # This value is to be ondemand for opt jobs
       - --e10s
     env:
         MOZHARNESS_SCRIPT: 'mozharness/scripts/marionette.py'
         MOZHARNESS_CONFIG: >
           mozharness/configs/marionette/prod_config.py
           mozharness/configs/remove_executables.py
     maxRunTime: 5400
   metadata:
--- a/testing/taskcluster/tasks/tests/fx_linux64_web_platform_tests.yml
+++ b/testing/taskcluster/tasks/tests/fx_linux64_web_platform_tests.yml
@@ -4,17 +4,17 @@
 task:
   workerType: desktop-test-xlarge
   payload:
     maxRunTime: 7200
     command:
       - --no-read-buildbot-config
       - --installer-url={{build_url}}
       - --test-packages-url={{test_packages_url}}
-      - --download-symbols=ondemand
+      - --download-symbols=true # This value is to be ondemand for opt jobs
       - --test-type=testharness
       - --total-chunk={{total_chunks}}
       - --this-chunk={{chunk}}
     env:
         MOZHARNESS_SCRIPT: 'mozharness/scripts/web_platform_tests.py'
         MOZHARNESS_CONFIG: >
           mozharness/configs/web_platform_tests/prod_config.py
           mozharness/configs/remove_executables.py
--- a/testing/taskcluster/tasks/tests/fx_linux64_web_platform_tests_e10s.yml
+++ b/testing/taskcluster/tasks/tests/fx_linux64_web_platform_tests_e10s.yml
@@ -4,17 +4,17 @@
 task:
   workerType: desktop-test-xlarge
   payload:
     maxRunTime: 7200
     command:
       - --no-read-buildbot-config
       - --installer-url={{build_url}}
       - --test-packages-url={{test_packages_url}}
-      - --download-symbols=ondemand
+      - --download-symbols=true # This value is to be ondemand for opt jobs
       - --test-type=testharness
       - --e10s
       - --total-chunk={{total_chunks}}
       - --this-chunk={{chunk}}
     env:
         MOZHARNESS_SCRIPT: 'mozharness/scripts/web_platform_tests.py'
         MOZHARNESS_CONFIG: >
           mozharness/configs/web_platform_tests/prod_config.py
--- a/testing/taskcluster/tasks/tests/fx_linux64_web_platform_tests_reftests.yml
+++ b/testing/taskcluster/tasks/tests/fx_linux64_web_platform_tests_reftests.yml
@@ -4,17 +4,17 @@
 task:
   workerType: desktop-test-xlarge
   payload:
     maxRunTime: 5400
     command:
       - --no-read-buildbot-config
       - --installer-url={{build_url}}
       - --test-packages-url={{test_packages_url}}
-      - --download-symbols=ondemand
+      - --download-symbols=true # This value is to be ondemand for opt jobs
       - --test-type=reftest
     env:
         MOZHARNESS_SCRIPT: 'mozharness/scripts/web_platform_tests.py'
         MOZHARNESS_CONFIG: >
           mozharness/configs/web_platform_tests/prod_config.py
           mozharness/configs/remove_executables.py
   metadata:
     name: '[TC] Linux64 web-platform-tests-reftests'
--- a/testing/taskcluster/tasks/tests/fx_linux64_web_platform_tests_reftests_e10s.yml
+++ b/testing/taskcluster/tasks/tests/fx_linux64_web_platform_tests_reftests_e10s.yml
@@ -3,17 +3,17 @@
   from: 'tasks/tests/fx_desktop_generic.yml'
 task:
   payload:
     maxRunTime: 5400
     command:
       - --no-read-buildbot-config
       - --installer-url={{build_url}}
       - --test-packages-url={{test_packages_url}}
-      - --download-symbols=ondemand
+      - --download-symbols=true # This value is to be ondemand for opt jobs
       - --test-type=reftest
       - --e10s
     env:
         MOZHARNESS_SCRIPT: 'mozharness/scripts/web_platform_tests.py'
         MOZHARNESS_CONFIG: >
           mozharness/configs/web_platform_tests/prod_config.py
           mozharness/configs/remove_executables.py
   metadata: