Bug 1354297 - Certificate expiry date is displayed in the page info dialog. r?johannh draft
authorPrathiksha <prathikshaprasadsuman@gmail.com>
Tue, 18 Jul 2017 13:44:44 +0530
changeset 610355 cb3a45efaaf4c4a067f30635425248751eba599b
parent 602051 f3483af8ecf997453064201c49c48a682c7f3c29
child 637846 40bbc7a63c1868704f8a4ddef1536d31fce5f9b4
push id68876
push userbmo:prathikshaprasadsuman@gmail.com
push dateTue, 18 Jul 2017 08:10:37 +0000
reviewersjohannh
bugs1354297
milestone56.0a1
Bug 1354297 - Certificate expiry date is displayed in the page info dialog. r?johannh MozReview-Commit-ID: 17mNmYDzGV9
browser/base/content/pageinfo/pageInfo.xul
browser/base/content/pageinfo/security.js
browser/locales/en-US/chrome/browser/pageInfo.dtd
--- a/browser/base/content/pageinfo/pageInfo.xul
+++ b/browser/base/content/pageinfo/pageInfo.xul
@@ -341,16 +341,25 @@
             <row id="security-identity-verifier-row">
               <label id="security-identity-verifier-label"
                      class="fieldLabel"
                      value="&securityView.identity.verifier;"
                      control="security-identity-verifier-value"/>
               <textbox id="security-identity-verifier-value"
                        class="fieldValue" readonly="true" />
             </row>
+            <!-- Date of Expiry -->
+            <row id="security-identity-validity-row">
+              <label id="security-identity-validity-label"
+                     class="fieldLabel"
+                     value="&securityView.identity.validity;"
+                     control="security-identity-validity-value"/>
+              <textbox id="security-identity-validity-value"
+                       class="fieldValue" readonly="true" />
+            </row>
           </rows>
         </grid>
         <spacer flex="1"/>
         <!-- Cert button -->
         <hbox id="security-view-cert-box" pack="end">
           <button id="security-view-cert" label="&securityView.certView;"
                   accesskey="&securityView.accesskey;"
                   oncommand="security.viewCert();"/>
--- a/browser/base/content/pageinfo/security.js
+++ b/browser/base/content/pageinfo/security.js
@@ -215,16 +215,17 @@ function securityOnLoad(uri, windowInfo)
                                                 info.cert.issuerName);
     }
   } else {
     // We don't have valid identity credentials.
     owner = pageInfoBundle.getString("securityNoOwner");
     verifier = pageInfoBundle.getString("notset");
   }
 
+  setText("security-identity-validity-value", info.cert.validity.notAfterLocalDay);
   setText("security-identity-owner-value", owner);
   setText("security-identity-verifier-value", verifier);
 
   /* Manage the View Cert button*/
   var viewCert = document.getElementById("security-view-cert");
   if (info.cert) {
     security._cert = info.cert;
     viewCert.collapsed = false;
--- a/browser/locales/en-US/chrome/browser/pageInfo.dtd
+++ b/browser/locales/en-US/chrome/browser/pageInfo.dtd
@@ -68,16 +68,17 @@
 <!ENTITY  securityView.accesskey "V">
 <!ENTITY  securityView.unknown   "Unknown">
 
 
 <!ENTITY  securityView.identity.header   "Website Identity">
 <!ENTITY  securityView.identity.owner    "Owner:">
 <!ENTITY  securityView.identity.domain   "Website:">
 <!ENTITY  securityView.identity.verifier "Verified by:">
+<!ENTITY  securityView.identity.validity "Expires on:">
 
 <!ENTITY  securityView.privacy.header                   "Privacy &amp; History">
 <!ENTITY  securityView.privacy.history                  "Have I visited this website prior to today?">
 <!ENTITY  securityView.privacy.cookies                  "Is this website storing information (cookies) on my computer?">
 <!ENTITY  securityView.privacy.viewCookies              "View Cookies">
 <!ENTITY  securityView.privacy.viewCookies.accessKey    "k">
 <!ENTITY  securityView.privacy.passwords                "Have I saved any passwords for this website?">
 <!ENTITY  securityView.privacy.viewPasswords            "View Saved Passwords">