Bug 1374735 - stop exposing devtools require to extensions ext-* files;r=kmag draft
authorJulian Descottes <jdescottes@mozilla.com>
Thu, 22 Jun 2017 21:04:02 +0200
changeset 614240 c9f0ebd73f43a127cca9b5d238349fe23d03c413
parent 614239 90f97a7deed06af7951de11338c6c0cae0867285
child 638821 635dc1df1a9bdaff89a062652539013ae42657dc
push id69963
push userjdescottes@mozilla.com
push dateMon, 24 Jul 2017 10:14:35 +0000
reviewerskmag
bugs1374735
milestone56.0a1
Bug 1374735 - stop exposing devtools require to extensions ext-* files;r=kmag There is no longer any file in components/extensions/ext-* that use require(). Therefore it should be ok to stop exposing it. MozReview-Commit-ID: EgZYBludlcy
toolkit/components/extensions/ExtensionCommon.jsm
--- a/toolkit/components/extensions/ExtensionCommon.jsm
+++ b/toolkit/components/extensions/ExtensionCommon.jsm
@@ -1107,18 +1107,16 @@ class SchemaAPIManager extends EventEmit
     Cu.import("resource://gre/modules/ExtensionAPI.jsm", global);
 
     XPCOMUtils.defineLazyGetter(global, "console", getConsole);
 
     XPCOMUtils.defineLazyModuleGetter(global, "ExtensionUtils",
                                       "resource://gre/modules/ExtensionUtils.jsm");
     XPCOMUtils.defineLazyModuleGetter(global, "XPCOMUtils",
                                       "resource://gre/modules/XPCOMUtils.jsm");
-    XPCOMUtils.defineLazyModuleGetter(global, "require",
-                                      "resource://devtools/shared/Loader.jsm");
 
     return global;
   }
 
   /**
    * Load an ext-*.js script. The script runs in its own scope, if it wishes to
    * share state with another script it can assign to the `global` variable. If
    * it wishes to communicate with this API manager, use `extensions`.