Bug 1410006 - ESLint should automatically ignore all crashtest directories; and clean up .eslintignore a bit. r?Mossop draft
authorMark Banner <standard8@mozilla.com>
Thu, 19 Oct 2017 09:55:40 +0100
changeset 683436 c7755188b1d95f9c7d8e0b398d6e493cce38652a
parent 683139 097044f71d4a4057dcc7bf76030f8b4cc379b56c
child 736654 c8dffd721aef6a29887d841e7dc311ae47cb0ce2
push id85383
push userbmo:standard8@mozilla.com
push dateThu, 19 Oct 2017 18:57:05 +0000
reviewersMossop
bugs1410006
milestone58.0a1
Bug 1410006 - ESLint should automatically ignore all crashtest directories; and clean up .eslintignore a bit. r?Mossop MozReview-Commit-ID: 93aNFQQcgrV
.eslintignore
--- a/.eslintignore
+++ b/.eslintignore
@@ -1,56 +1,61 @@
 # Always ignore node_modules.
 **/node_modules/**/*.*
 
+# Always ignore crashtests - specially crafted files that originally caused a
+# crash.
+**/crashtests/**
+
 # Exclude expected objdirs.
 obj*/**
 
 # We ignore all these directories by default, until we get them enabled.
 # If you are enabling a directory, please add directory specific exclusions
 # below.
 chrome/**
 docshell/**
 editor/**
-embedding/**
 extensions/cookie/**
 extensions/spellcheck/**
 extensions/universalchardet/**
 gfx/**
 image/**
 intl/**
 layout/**
 media/**
 memory/**
 modules/**
 netwerk/**
 parser/**
-python/**
 rdf/**
-servo/**
 tools/update-packaging/**
 uriloader/**
-view/**
 widget/**
 
 # We currently have no js files in these directories, so we ignore them by
 # default to aid ESLint's performance.
 build/**
 config/**
 db/**
+embedding/**
 gradle/**
 hal/**
 mfbt/**
 mozglue/**
 nsprpub/**
 other-licenses/**
 probes/**
 startupcache/**
 xpfe/**
 
+# These directories only contain crashtests, but we still skip the whole
+# directory to aid performance.
+view/**
+
 # browser/ exclusions
 browser/app/**
 browser/branding/**/firefox-branding.js
 # Gzipped test file.
 browser/base/content/test/general/gZipOfflineChild.html
 browser/base/content/test/urlbar/file_blank_but_not_blank.html
 # New tab is likely to be replaced soon.
 browser/base/content/newtab/**
@@ -277,28 +282,34 @@ mobile/android/chrome/content/about.js
 # Not much JS to lint and non-standard at that
 mobile/android/installer/
 mobile/android/locales/
 
 # Non-standard `(catch ex if ...)`
 mobile/android/chrome/content/browser.js
 mobile/android/components/Snippets.js
 
+# Only contains non-standard test files.
+python/**
+
 # security/ exclusions (pref files).
 security/manager/ssl/security-prefs.js
 
 # NSS / taskcluster only.
 security/nss/**
 
 # services/ exclusions
 
 # Uses `#filter substitution`
 services/sync/modules/constants.js
 services/sync/services-sync.js
 
+# Servo is imported.
+servo/**
+
 # Remote protocol exclusions
 testing/marionette/test_*.js
 testing/marionette/atom.js
 testing/marionette/legacyaction.js
 testing/marionette/client
 testing/marionette/doc
 testing/marionette/harness