Bug 1359603 - Tweak style adjust ordering to better match Gecko. r=heycam draft
authorJ. Ryan Stinnett <jryans@gmail.com>
Wed, 26 Apr 2017 11:30:05 -0500
changeset 568929 c73a1e1841c05c90ba57a72e2465670d1857d7c3
parent 568928 e5943a9393e5e8514b914d674430c08df7bc77eb
child 626066 a77809a57e45d18e6b4ef60d81a0caddc6548b2b
push id56023
push userbmo:jryans@gmail.com
push dateWed, 26 Apr 2017 19:03:45 +0000
reviewersheycam
bugs1359603
milestone55.0a1
Bug 1359603 - Tweak style adjust ordering to better match Gecko. r=heycam To ease comparison between Gecko's `nsStyleContext::ApplyStyleFixups` and the Servo equivalent, move them into a similar ordering. MozReview-Commit-ID: GV89pbzA8IH
servo/components/style/style_adjuster.rs
--- a/servo/components/style/style_adjuster.rs
+++ b/servo/components/style/style_adjuster.rs
@@ -255,26 +255,23 @@ impl<'a> StyleAdjuster<'a> {
                   skip_root_and_element_display_fixup: bool) {
         #[cfg(feature = "gecko")]
         {
             self.adjust_for_text_combine_upright(layout_parent_style);
         }
         self.adjust_for_top_layer();
         self.blockify_if_necessary(layout_parent_style,
                                    skip_root_and_element_display_fixup);
-        self.adjust_for_writing_mode(layout_parent_style);
         self.adjust_for_position();
-
         self.adjust_for_overflow();
         #[cfg(feature = "gecko")]
         {
             self.adjust_for_contain();
         }
-
         #[cfg(feature = "servo")]
         {
             self.adjust_for_alignment(layout_parent_style);
         }
-
         self.adjust_for_border_width();
         self.adjust_for_outline();
+        self.adjust_for_writing_mode(layout_parent_style);
     }
 }