Bug 1419819 - Remove html|button padding rule from common stylesheet. r=jaws
authorScott Wu <scottcwwu@gmail.com>
Thu, 30 Nov 2017 11:24:44 +0800
changeset 706811 c32c3cd8c898fe0bf44775680adcab530aaf2eed
parent 706810 2cf30748e1c1073157b6ed0e81de20d2f5688d49
child 706812 ecc5c1b8efc4111dfa9aba2f49666c9edbe5fbd6
push id91936
push userbmo:emilio@crisal.io
push dateMon, 04 Dec 2017 10:24:39 +0000
reviewersjaws
bugs1419819, 1413162
milestone59.0a1
Bug 1419819 - Remove html|button padding rule from common stylesheet. r=jaws Bug 1413162 added the html|button padding rule intended to normalize the way buttons are styled in preferences, but ended up causing problems for buttons outside of preferences, especially because !important keyword is used. This bug reverts that change. MozReview-Commit-ID: FFQt2k6mCHE
browser/extensions/formautofill/content/manageDialog.css
browser/extensions/formautofill/skin/shared/editDialog.css
toolkit/themes/shared/in-content/common.inc.css
--- a/browser/extensions/formautofill/content/manageDialog.css
+++ b/browser/extensions/formautofill/content/manageDialog.css
@@ -1,16 +1,21 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 div {
   display: flex;
 }
 
+button {
+  padding-right: 10px;
+  padding-left: 10px;
+}
+
 fieldset {
   margin: 0;
   padding: 0;
   border: none;
 }
 
 fieldset > legend {
   box-sizing: border-box;
--- a/browser/extensions/formautofill/skin/shared/editDialog.css
+++ b/browser/extensions/formautofill/skin/shared/editDialog.css
@@ -32,16 +32,21 @@ div > span {
 option {
   padding: 0.3em 0.5em;
 }
 
 textarea {
   resize: none;
 }
 
+button {
+  padding-right: 10px;
+  padding-left: 10px;
+}
+
 input,
 select {
   box-sizing: border-box;
   flex: 1 0 auto;
 }
 
 #controls-container {
   flex: 0 1 100%;
--- a/toolkit/themes/shared/in-content/common.inc.css
+++ b/toolkit/themes/shared/in-content/common.inc.css
@@ -264,17 +264,16 @@ xul|button.primary:not([disabled="true"]
   background-color: var(--in-content-primary-button-background-active);
 }
 
 xul|colorpicker[type="button"] {
   padding: 6px;
   width: 50px;
 }
 
-html|button,
 xul|button > xul|*.button-box,
 xul|menulist > xul|*.menulist-label-box {
   padding-right: 10px !important;
   padding-left: 10px !important;
 }
 
 xul|menulist > xul|*.menulist-label-box > xul|*.menulist-icon[src] {
   margin-inline-end: 5px;