Bug 1466242 Look for Sprintf.h instead of Assertions.h in the symbolstore test r=glandium
authorTom Ritter <tom@mozilla.com>
Tue, 05 Jun 2018 10:44:03 -0500
changeset 805586 badcfe94e6a79792ff5bb6ed96436977d0da888c
parent 805585 1eee411e9a96bacd910bc15e3fd159a6385fa6dd
child 805587 295900f1ae690684391457c12a8b32c20458442a
push id112702
push userbmo:mh+mozilla@glandium.org
push dateFri, 08 Jun 2018 01:32:47 +0000
reviewersglandium
bugs1466242
milestone62.0a1
Bug 1466242 Look for Sprintf.h instead of Assertions.h in the symbolstore test r=glandium It turns out sometimes (in the LTO+CFI case at least) Assertions.h will not be present in the opt build, presumably because it was optimized out. MozReview-Commit-ID: GB3GIoSdIUK
toolkit/crashreporter/tools/unit-symbolstore.py
--- a/toolkit/crashreporter/tools/unit-symbolstore.py
+++ b/toolkit/crashreporter/tools/unit-symbolstore.py
@@ -530,15 +530,15 @@ class TestFunctional(HelperMixin, unitte
             if not os.path.isdir(mozpath.join(self.topsrcdir, '.hg')):
                 return
             for line in match_lines:
                 filename = line.split(None, 2)[2]
                 self.assertEqual('hg:', filename[:3])
         # Check that nsBrowserApp.cpp is listed as a FILE line, and that
         # it was properly mapped to the source repo.
         check_hg_path(file_lines, 'nsBrowserApp.cpp')
-        # Also check Assertions.h to verify that files from dist/include
+        # Also check Sprintf.h to verify that files from dist/include
         # are properly mapped.
-        check_hg_path(file_lines, 'mfbt/Assertions.h')
+        check_hg_path(file_lines, 'mfbt/Sprintf.h')
 
 
 if __name__ == '__main__':
     mozunit.main()