Bug 1291049 - Remove unused parameters from node-highlight event;r=pbro draft
authorJulian Descottes <jdescottes@mozilla.com>
Mon, 28 Nov 2016 22:47:02 +0100
changeset 444825 ba8a5712d15f
parent 442775 0ddfec7126ec
child 444826 862c4410d170
push id37382
push userjdescottes@mozilla.com
push dateMon, 28 Nov 2016 22:26:48 +0000
reviewerspbro
bugs1291049
milestone53.0a1
Bug 1291049 - Remove unused parameters from node-highlight event;r=pbro The two additional parameters sent with the node-highlight event are never used. Also toSource is a Firefox only API, in the context of devtools-html it would be nice to get rid of it. MozReview-Commit-ID: FRo6J8E4zb8
devtools/client/framework/toolbox-highlighter-utils.js
--- a/devtools/client/framework/toolbox-highlighter-utils.js
+++ b/devtools/client/framework/toolbox-highlighter-utils.js
@@ -235,17 +235,17 @@ exports.getHighlighterUtils = function (
     if (isRemoteHighlightable()) {
       yield toolbox.highlighter.showBoxModel(nodeFront, options);
     } else {
       // If the target doesn't have the highlighter actor, revert to the
       // walker's highlight method, which draws a simple outline
       yield toolbox.walker.highlight(nodeFront);
     }
 
-    toolbox.emit("node-highlight", nodeFront, options.toSource());
+    toolbox.emit("node-highlight");
   });
 
   /**
    * This is a convenience method in case you don't have a nodeFront but a
    * valueGrip. This is often the case with VariablesView properties.
    * This method will simply translate the grip into a nodeFront and call
    * highlightNodeFront, so it has the same signature.
    * @see highlightNodeFront