Bug 1083897, part 1 - Require leak logs for tab processes on desktop. r=khuey
authorAndrew McCreight <continuation@gmail.com>
Tue, 13 Jan 2015 12:32:35 -0800
changeset 236757 b8ead5a0b265e1fc15c7d664c4d82dca0be3e6b3
parent 236756 e097e82fa29bd082cb9920844f615e34cb8eb89a
child 236758 783763e3562dcab6f3b6415b45392d725a6bb742
push id411
push usermartin.thomson@gmail.com
push dateWed, 14 Jan 2015 00:17:02 +0000
reviewerskhuey
bugs1083897
milestone38.0a1
Bug 1083897, part 1 - Require leak logs for tab processes on desktop. r=khuey
testing/mochitest/mochitest_options.py
--- a/testing/mochitest/mochitest_options.py
+++ b/testing/mochitest/mochitest_options.py
@@ -654,19 +654,18 @@ class MochitestOptions(optparse.OptionPa
             options.e10s = True
 
         options.leakThresholds = {
             "default": options.defaultLeakThreshold,
             "tab": 2000000, # See dependencies of bug 1051230.
             "geckomediaplugin": 20000, # GMP rarely gets a log, but when it does, it leaks a little.
         }
 
-        # Bug 1051230 - Leak logging does not yet work for tab processes on desktop.
         # Bug 1065098 - The geckomediaplugin process fails to produce a leak log for some reason.
-        options.ignoreMissingLeaks = ["tab", "geckomediaplugin"]
+        options.ignoreMissingLeaks = ["geckomediaplugin"]
 
         return options
 
 
 class B2GOptions(MochitestOptions):
     b2g_options = [
         [["--b2gpath"],
         { "action": "store",
@@ -866,15 +865,15 @@ class B2GOptions(MochitestOptions):
         options.app = temp
         options.sslPort = tempSSL
         options.httpPort = tempPort
 
         # Bug 1071866 - B2G Mochitests do not always produce a leak log.
         options.ignoreMissingLeaks.append("default")
 
         # Bug 1070068 - Leak logging does not work for tab processes on B2G.
-        assert "tab" in options.ignoreMissingLeaks, "Ignore failures for tab processes on B2G"
+        options.ignoreMissingLeaks.append("tab")
 
         return options
 
     def elf_arm(self, filename):
         data = open(filename, 'rb').read(20)
         return data[:4] == "\x7fELF" and ord(data[18]) == 40 # EM_ARM