Bug 1077047 - "Refine footer banner in about:feedback" . r=margaret.leibovic
authorvivek <vivekb.balakrishnan>
Fri, 10 Oct 2014 07:51:00 +0200
changeset 210305 b648f59fb34ec9f4dd15ef3ac50c6e31945bd8f6
parent 210304 4b9af1d6b1a8317c82ac7e1e0ef20d9817dcd6b2
child 210306 31ec406e700102bd73b674dda326e156d0dcacf9
push id1
push userroot
push dateMon, 20 Oct 2014 17:29:22 +0000
reviewersmargaret.leibovic
bugs1077047
milestone36.0a1
Bug 1077047 - "Refine footer banner in about:feedback" . r=margaret.leibovic
mobile/android/chrome/content/aboutFeedback.js
mobile/android/chrome/content/aboutFeedback.xhtml
mobile/android/themes/core/aboutFeedback.css
--- a/mobile/android/chrome/content/aboutFeedback.js
+++ b/mobile/android/chrome/content/aboutFeedback.js
@@ -62,17 +62,19 @@ function init() {
 
   document.getElementById("open-play-store").addEventListener("click", openPlayStore, false);
   document.forms[0].addEventListener("submit", sendFeedback, false);
   for (let anchor of document.querySelectorAll(".no-thanks")) {
     anchor.addEventListener("click", evt => window.close(), false);
   }
 
   let sumoLink = Services.urlFormatter.formatURLPref("app.support.baseURL");
-  document.getElementById("sumo-link").href = sumoLink;
+  document.getElementById("help-section").addEventListener("click", function() {
+    window.open(sumoLink, "_blank");
+  }, false);
 
   window.addEventListener("popstate", function (aEvent) {
 	updateActiveSection(aEvent.state ? aEvent.state.section : "intro")
   }, false);
 
   // Fill "Last visited site" input with most recent history entry URL.
   Services.obs.addObserver(function observer(aSubject, aTopic, aData) {
     document.getElementById("last-url").value = aData;
--- a/mobile/android/chrome/content/aboutFeedback.xhtml
+++ b/mobile/android/chrome/content/aboutFeedback.xhtml
@@ -77,14 +77,14 @@
       <div class="message">&sad.thanksMessageTop;</div>
       <div class="message">&sad.thanksMessageBottom;</div>
     </div>
   </section>
 
   <footer>
     <div id="help-section">
       <img id="sumo-icon" />
-      <span>&support.pre3;<a id="sumo-link">&support.link2;</a>&support.post3;</span>
+      <span>&support.pre3;<span class="link">&support.link2;</span>&support.post3;</span>
     </div>
   </footer>
   <script type="application/javascript;version=1.8" src="chrome://browser/content/aboutFeedback.js"></script>
 </body>
 </html>
--- a/mobile/android/themes/core/aboutFeedback.css
+++ b/mobile/android/themes/core/aboutFeedback.css
@@ -185,18 +185,19 @@ footer {
   font-size: 16px;
   width: 100%;
   background-color: #0092DB;
   border-radius: 4px;
   border-width: 0;
   color: #fff;
 }
 
-#sumo-link {
+.link {
   color: #222;
+  text-decoration: underline;
 }
 
 @media screen and (max-height: 400px) {
   body {
     padding-top: 40px;
   }
 
   .bottom-links {