Bug 1354515 - Removed duplicate ESLint rules in security/manager r?Standard8 draft
authorRajesh Kathiriya <rajesh.kathiriya507@gmail.com>
Sat, 22 Apr 2017 15:41:34 +0530
changeset 566737 b57e73013243baad2679f921ff2288f81272d9b8
parent 566736 42c8a716081e6a8aa33c1e61944f36f6f89245fb
child 625400 aa6215b967f088c953b13d617f63b5954e72c899
push id55308
push userbmo:rajesh.kathiriya507@gmail.com
push dateSat, 22 Apr 2017 10:15:05 +0000
reviewersStandard8
bugs1354515
milestone55.0a1
Bug 1354515 - Removed duplicate ESLint rules in security/manager r?Standard8 MozReview-Commit-ID: 8H7iE1wu2hW
security/manager/.eslintrc.js
--- a/security/manager/.eslintrc.js
+++ b/security/manager/.eslintrc.js
@@ -3,55 +3,31 @@
 module.exports = {
   "extends": [
     "plugin:mozilla/recommended"
   ],
   "rules": {
     // Enforce return statements in callbacks of array methods.
     "array-callback-return": "error",
 
-    // Braces only needed for multi-line arrow function blocks
-    "arrow-body-style": ["error", "as-needed"],
-
-    // Commas at the end of the line not the start
-    "comma-style": "error",
-
     // Verify calls of super() in constructors.
     "constructor-super": "error",
 
-    // Require braces around blocks that start a new line
-    "curly": ["error", "multi-line"],
-
     // Require default case in switch statements.
     "default-case": "error",
 
     // Require `foo.bar` dot notation instead of `foo["bar"]` notation.
     "dot-notation": "error",
 
-    // Always require a trailing EOL
-    "eol-last": "error",
-
     // No spaces between function name and parentheses.
     "func-call-spacing": ["error", "never"],
 
-    // Require function* name()
-    "generator-star-spacing": ["error", {"before": false, "after": true}],
-
-    // Space after colon not before in property declarations
-    "key-spacing": ["error", { "beforeColon": false, "afterColon": true, "mode": "minimum" }],
-
-    // Always require parenthesis for new calls
-    "new-parens": "error",
-
     // Disallow use of alert(), confirm(), and prompt().
     "no-alert": "error",
 
-    // Use [] instead of Array()
-    "no-array-constructor": "error",
-
     // Disallow use of arguments.caller or arguments.callee.
     "no-caller": "error",
 
     // Disallow likely erroneous `switch` scoped lexical declarations in
     // case/default clauses.
     "no-case-declarations": "error",
 
     // Disallow modifying variables of class declarations.
@@ -80,19 +56,16 @@ module.exports = {
 
     // Disallow case statement fallthrough without explicit `// falls through`
     // annotation.
     "no-fallthrough": "error",
 
     // No reassigning native JS objects or read only globals.
     "no-global-assign": "error",
 
-    // Disallow implied eval().
-    "no-implied-eval": "error",
-
     // Disallow primitive wrapper instances like `new Boolean(false)`, which
     // seem like they should act like primitives but don't.
     "no-new-wrappers": "error",
 
     // Disallow use of assignment in return statement.
     "no-return-assign": ["error", "always"],
 
     // Disallow use of the comma operator.
@@ -106,19 +79,16 @@ module.exports = {
 
     // Disallow use of this/super before calling super() in constructors.
     "no-this-before-super": "error",
 
     // Disallow throwing literals (eg. |throw "error"| instead of
     // |throw new Error("error")|)
     "no-throw-literal": "error",
 
-    // No using undeclared variables
-    "no-undef": "error",
-
     // Disallow unmodified loop conditions.
     "no-unmodified-loop-condition": "error",
 
     // Disallow ternary operators when simpler alternatives exist.
     "no-unneeded-ternary": "error",
 
     // No expressions where a statement is expected
     "no-unused-expressions": "error",