Bug 1411796 - [taskgraph] Skip parameters.rst doc verification if parameters.strict is False, r?dustin draft
authorAndrew Halberstadt <ahalberstadt@mozilla.com>
Wed, 25 Oct 2017 20:27:17 -0400
changeset 686555 afd5a8ef98afe1f73b2a5b12136ffc39d6b5f58a
parent 685889 3d0093f961eec929caa370444cd0f7fcbfbc82bc
child 737397 383814981057f8cf733d08bcc2c1e5b6f471ad13
push id86209
push userahalberstadt@mozilla.com
push dateThu, 26 Oct 2017 00:29:16 +0000
reviewersdustin
bugs1411796
milestone58.0a1
Bug 1411796 - [taskgraph] Skip parameters.rst doc verification if parameters.strict is False, r?dustin This is needed to prevent parameter mismatch errors when using |mach try fuzzy| from an older revision. This can happen if the parameters.yml is being downloaded from a commit with a recently added parameter. MozReview-Commit-ID: 4NxCM7i8B4W
taskcluster/taskgraph/generator.py
--- a/taskcluster/taskgraph/generator.py
+++ b/taskcluster/taskgraph/generator.py
@@ -282,16 +282,19 @@ class TaskGraphGenerator(object):
             try:
                 k, v = self._run.next()
             except StopIteration:
                 raise AttributeError("No such run result {}".format(name))
             self._run_results[k] = v
         return self._run_results[name]
 
     def verify_parameters(self, parameters):
+        if not parameters.strict:
+            return
+
         parameters_dict = dict(**parameters)
         verify_docs(
             filename="parameters.rst",
             identifiers=parameters_dict.keys(),
             appearing_as="inline-literal"
          )
 
     def verify_kinds(self, kinds):