ContentParent::RecvCreateWindow should always set an nsresult outparam. :( draft
authorMike Conley <mconley@mozilla.com>
Tue, 24 May 2016 15:41:35 -0400
changeset 370978 af7767382bdbc02ecca4f9dcfd774487ffabcb57
parent 370977 a682133e299914591564fd1deb0137eb5fff9770
child 370979 c6100aa014baa5edf69c38f257bea7336862d8a4
push id19190
push usermconley@mozilla.com
push dateWed, 25 May 2016 17:23:31 +0000
milestone49.0a1
ContentParent::RecvCreateWindow should always set an nsresult outparam. :( MozReview-Commit-ID: 79FYAMBIDef
dom/ipc/ContentParent.cpp
--- a/dom/ipc/ContentParent.cpp
+++ b/dom/ipc/ContentParent.cpp
@@ -5412,16 +5412,17 @@ ContentParent::RecvCreateWindow(PBrowser
                                 bool* aWindowIsNew,
                                 InfallibleTArray<FrameScriptInfo>* aFrameScripts,
                                 nsCString* aURLToLoad,
                                 TextureFactoryIdentifier* aTextureFactoryIdentifier,
                                 uint64_t* aLayersId)
 {
   // We always expect to open a new window here. If we don't, it's an error.
   *aWindowIsNew = true;
+  *aResult = NS_OK;
 
   // The content process should never be in charge of computing whether or
   // not a window should be private or remote - the parent will do that.
   const uint32_t badFlags =
         nsIWebBrowserChrome::CHROME_PRIVATE_WINDOW
       | nsIWebBrowserChrome::CHROME_NON_PRIVATE_WINDOW
       | nsIWebBrowserChrome::CHROME_PRIVATE_LIFETIME
       | nsIWebBrowserChrome::CHROME_REMOTE_WINDOW;