Bug 1230692. Fix WebAudioDecodeJob to properly suppress exceptions from its callbacks. r=ehsan
authorBoris Zbarsky <bzbarsky@mit.edu>
Mon, 07 Dec 2015 18:42:11 -0500
changeset 314605 ae19fb16cb392f557466d5eb527040adb959d2be
parent 314604 493f9c9164b7b8e38257064b4eb718a16c5546ac
child 314606 87caa5721cd900ab113ba5991e0d7616b84bd076
push id8237
push userjbeich@vfemail.net
push dateTue, 08 Dec 2015 12:55:06 +0000
reviewersehsan
bugs1230692
milestone45.0a1
Bug 1230692. Fix WebAudioDecodeJob to properly suppress exceptions from its callbacks. r=ehsan
dom/media/webaudio/MediaBufferDecoder.cpp
--- a/dom/media/webaudio/MediaBufferDecoder.cpp
+++ b/dom/media/webaudio/MediaBufferDecoder.cpp
@@ -594,18 +594,17 @@ WebAudioDecodeJob::OnFailure(ErrorCode a
                                   NS_LITERAL_CSTRING("Media"),
                                   doc,
                                   nsContentUtils::eDOM_PROPERTIES,
                                   errorMessage);
 
   // Ignore errors in calling the callback, since there is not much that we can
   // do about it here.
   if (mFailureCallback) {
-    ErrorResult rv;
-    mFailureCallback->Call(rv);
+    mFailureCallback->Call();
   }
 
   mPromise->MaybeReject(NS_ERROR_DOM_ENCODING_NOT_SUPPORTED_ERR);
 
   mContext->RemoveFromDecodeQueue(this);
 }
 
 size_t