Bug 1398346 - Hide the 'Open File' status label for failed downloads and/ or downloads where the file went missing for items in the Downloads subview in the Library panel. r?Paolo draft
authorMike de Boer <mdeboer@mozilla.com>
Mon, 25 Sep 2017 18:37:30 +0200
changeset 669918 aafaa8621bd4791aad72f3f850e2c4c9fcec3bfa
parent 669872 db45ffac661dfd9e738574175fcd91b7f25cf13e
child 669934 85fcec2a5c7600f3ba2565f94a7cce92510c6008
push id81468
push usermdeboer@mozilla.com
push dateMon, 25 Sep 2017 16:46:05 +0000
reviewersPaolo
bugs1398346
milestone58.0a1
Bug 1398346 - Hide the 'Open File' status label for failed downloads and/ or downloads where the file went missing for items in the Downloads subview in the Library panel. r?Paolo MozReview-Commit-ID: 1j9tkqydyVZ
browser/components/downloads/content/downloads.css
--- a/browser/components/downloads/content/downloads.css
+++ b/browser/components/downloads/content/downloads.css
@@ -213,21 +213,25 @@ richlistitem.download button {
 .subviewbutton.download {
   -moz-binding: url("chrome://browser/content/downloads/download.xml#download-subview-toolbarbutton");
 }
 
 /* When a Download is hovered that has an [openLabel] attribute set, which means
    that the file exists and can be opened, hide the status label.
    When a Download is hovered - specifically on the secondary action button - that
    has a [retryLabel] attribute set, which means that the file does not exist and
-   the download failed earlier, hide the status label. */
-.subviewbutton.download:hover:-moz-any([openLabel],[retryLabel][buttonover]) > .toolbarbutton-text > .status-full,
+   the download failed earlier, hide the status label.
+   When a Download is hovered that has the [exists] attribute set and does not
+   have a [retryLabel] attribute set, hide the status label. */
+.subviewbutton.download:hover:-moz-any([openLabel],[retryLabel][buttonover],[exists]:not([retryLabel])) > .toolbarbutton-text > .status-full,
 /* When a Download is not hovered at all or the secondary action button is hovered,
-   hide the 'Open File' status label. */
-.subviewbutton.download:-moz-any(:not(:hover),[buttonover]) > .toolbarbutton-text > .status-open,
+   hide the 'Open File' status label.
+   When a Download has a [retryLabel] attribute set or does not have an [exists]
+   attribute set, hide the 'Open File' status label. */
+.subviewbutton.download:-moz-any(:not(:hover),[buttonover],[retryLabel],:not([exists])) > .toolbarbutton-text > .status-open,
 /* When a Download is not hovered at all, or when it's hovered but specifically
    not the secondary action button or when the [retryLabel] is not set, hide the
    'Retry Downloads' label. */
 .subviewbutton.download:-moz-any(:not(:hover),:hover:not([buttonover]),:not([retryLabel])) > .toolbarbutton-text > .status-retry,
 /* When a Download is not hovered at all, or when it's hovered but specifically
    not the secondary action button or when the file does not exist, hide the
    'Open Containing Folder' label. */
 .subviewbutton.download:-moz-any(:not(:hover),:hover:not([buttonover]),:not([exists])) > .toolbarbutton-text > .status-show,