Bug 1382774 - Pre: Don't fail |mach android gradle-dependencies|. r=sebastian draft
authorNick Alexander <nalexander@mozilla.com>
Wed, 19 Jul 2017 12:54:10 -0700
changeset 612527 a6e1f2e957ea56f7dde754f9eaa102d4a8edbbfc
parent 612315 d3ebc6448a62d38b134e957eb4fd5c2565ad40b8
child 612528 c945acabcedd98439a0ca0e26251bab1a41de197
push id69515
push usernalexander@mozilla.com
push dateThu, 20 Jul 2017 19:18:01 +0000
reviewerssebastian
bugs1382774
milestone56.0a1
Bug 1382774 - Pre: Don't fail |mach android gradle-dependencies|. r=sebastian MozReview-Commit-ID: CI2Kqb1kceP
mobile/android/mach_commands.py
--- a/mobile/android/mach_commands.py
+++ b/mobile/android/mach_commands.py
@@ -289,19 +289,22 @@ class MachCommands(MachCommandBase):
             'app:findbugsHtmlOfficialPhotonDebug',
             'app:lintOfficialPhotonDebug',
             # Does not include Gecko binaries -- see mobile/android/gradle/with_gecko_binaries.gradle.
             'geckoview:assembleWithoutGeckoBinaries',
             # So that we pick up the test dependencies for the builders.
             'geckoview_example:assembleWithoutGeckoBinaries',
             'geckoview_example:assembleWithoutGeckoBinariesAndroidTest',
         ]
+        # We don't want to gate producing dependency archives on clean
+        # lint or checkstyle, particularly because toolchain versions
+        # can change the outputs for those processes.
         ret = self.gradle(gradle_targets + ["--continue"] + args, verbose=True)
 
-        return ret
+        return 0
 
 
     @Command('gradle', category='devenv',
         description='Run gradle.',
         conditions=[conditions.is_android])
     @CommandArgument('-v', '--verbose', action='store_true',
         help='Verbose output for what commands the build is running.')
     @CommandArgument('args', nargs=argparse.REMAINDER)