Bug 1398655 - Remove unused color resources in colors.xml. r=nechen
authorJing-wei Wu <topwu.tw@gmail.com>
Tue, 29 Aug 2017 15:08:43 +0800
changeset 662664 a57eaa7832b2322039da509b64ecca86f98a5f91
parent 662593 307b5682dec342ab187af9e13ee006c36bd09da8
child 662665 b86983c73434cbe6705631c9bf76d0b33b6dc6aa
push id79159
push userhikezoe@mozilla.com
push dateMon, 11 Sep 2017 23:25:15 +0000
reviewersnechen
bugs1398655
milestone57.0a1
Bug 1398655 - Remove unused color resources in colors.xml. r=nechen MozReview-Commit-ID: 6lPno8C3GhE
mobile/android/app/lint.xml
mobile/android/app/src/photon/res/values/colors.xml
--- a/mobile/android/app/lint.xml
+++ b/mobile/android/app/lint.xml
@@ -214,18 +214,16 @@
     <issue id="UnlocalizedSms" severity="error" />
     <issue id="UnusedNamespace" severity="error" />
     <issue id="UnusedQuantity" severity="error" />
     <issue id="UnusedResources" severity="error">
         <!-- The moz.build based build system leaves a .mkdir.done file lying around in the
              preprocessed_resources res/raw folder. Lint reports it as unused. We should get
              rid of the file eventually. See bug 1268948. -->
         <ignore path="**/raw/.mkdir.done" />
-        <!-- bug 1375351 - To clean unused color codes -->
-        <ignore path="src/photon/res/values/colors.xml"/>
     </issue>
     <issue id="Usability" severity="error" />
     <issue id="UseCheckPermission" severity="error" />
     <issue id="UseCompoundDrawables" severity="error" />
     <issue id="UselessLeaf" severity="error" />
     <issue id="UsesMinSdkAttributes" severity="error" />
     <issue id="UsingHttp" severity="error" />
     <issue id="ViewHolder" severity="error" />
--- a/mobile/android/app/src/photon/res/values/colors.xml
+++ b/mobile/android/app/src/photon/res/values/colors.xml
@@ -40,47 +40,36 @@
 
     <color name="photon_tabs_tray_bg">#272727</color>
     <color name="photon_highlight">#0A84FF</color>
     <color name="photon_highlight_private">#AC39FF</color>
     <color name="photon_loading_indicator_light">#00DCFC</color>
     <color name="photon_loading_indicator_light_private">#FF1AD9</color>
     <color name="photon_loading_indicator_dark">#00A2FE</color>
     <color name="photon_loading_indicator_dark_private">#9400FF</color>
-    <color name="photon_menu_bg">#F9F9FA</color>
-    <color name="photon_menu_bg_private">#38383D</color>
     <color name="photon_icon">#272727</color>
     <color name="photon_icon_disabled">#33272727</color>
-    <color name="photon_icon_pressed">@color/photon_icon</color>
     <color name="photon_icon_private">#FFFFFF</color>
     <color name="photon_icon_private_disabled">#33FFFFFF</color>
-    <color name="photon_icon_private_pressed">@color/photon_icon_private</color>
-    <color name="photon_icon_lock">#16DA00</color>
 
     <color name="photon_notification_bg">#0096DD</color>
 
     <!-- opacity: 20% -->
     <color name="photon_notification_bg_pressed">#33000000</color>
 
     <color name="photon_toolbar_text_color">#272727</color>
     <color name="photon_toolbar_text_color_private">#FFFFFF</color>
     <color name="photon_toolbar_image_tint">@color/photon_toolbar_text_color</color>
     <color name="photon_toolbar_image_tint_private">@color/photon_toolbar_text_color_private</color>
     <color name="photon_toolbar_bg">#F7FAFC</color>
     <color name="photon_toolbar_bg_private">#38383D</color>
 
-    <color name="photon_two_line_page_row_bg">#FFFFFF</color>
-    <color name="photon_two_line_page_row_bg_private">#414146</color>
-
     <color name="photon_search_item_text">@color/photon_text_main</color>
     <color name="photon_search_item_text_private">@color/photon_text_main_private</color>
 
-    <color name="photon_home_list_divider">@color/photon_two_line_page_row_bg</color>
-    <color name="photon_home_list_divider_private">@color/photon_two_line_page_row_bg_private</color>
-
     <color name="photon_url_bar_blocked">#D70022</color>
     <color name="photon_url_bar_blocked_private">#D70022</color>
     <color name="photon_url_bar_certificate_owner">#05A700</color>
     <color name="photon_url_bar_certificate_owner_private">#16DA00</color>
     <color name="photon_url_bar_domain">@color/photon_text_main</color>
     <color name="photon_url_bar_domain_private">@color/photon_text_main_private</color>
     <color name="photon_url_bar_bg">#80FFFFFF</color>
 
@@ -167,42 +156,30 @@
 
     <!-- Restricted profiles palette -->
 
     <color name="restricted_profile_background_gold">#ffffcb51</color>
     <color name="restricted_profile_background_green">#1aaa86</color>
 
     <!-- Non-palette colors -->
 
-    <!-- Synced w/ toolbar_grey -->
-    <color name="background_normal_lwt">#DDEBEBF0</color>
-
     <color name="highlight">#33000000</color>
     <color name="highlight_focused">#1A000000</color>
     <color name="highlight_dark">#33FFFFFF</color>
     <color name="highlight_dark_focused">#1AFFFFFF</color>
 
-    <!-- Synced w/ toolbar_grey_pressed -->
-    <color name="tablet_highlight_lwt">#AAD7D7DC</color>
-
-    <!-- Synced w/ tabs_tray_grey_pressed -->
-    <color name="tablet_highlight_dark_lwt">#AA45494E</color>
-
     <!-- (bug 1077195) Focused state values are temporary. -->
     <color name="tablet_highlight_focused">#C0C9D0</color>
 
     <!-- highlight on shaped button: 20% white over text_and_tabs_tray_grey -->
     <color name="highlight_shaped">#FF696D71</color>
 
     <!-- highlight-focused on shaped button: 10% white over text_and_tabs_tray_grey -->
     <color name="highlight_shaped_focused">#FF565B60</color>
 
-    <!-- highlight on private nav button: 20% white over private_toolbar_grey -->
-    <color name="highlight_nav_pb">#FF545654</color>
-
     <color name="dark_transparent_overlay">#99000000</color>
 
     <!-- Firstrun tour -->
     <color name="firstrun_pager_header">#E8E8E8</color>
 
     <!-- Tab Queue -->
     <color name="tab_queue_dismiss_button_foreground">#16A3DF</color>
     <color name="tab_queue_dismiss_button_foreground_pressed">#1193CB</color>
@@ -279,18 +256,16 @@
 
     <!-- Canvas delegate paint color -->
     <color name="canvas_delegate_paint">#FFFF0000</color>
 
     <!-- Top sites thumbnail colors -->
     <color name="top_site_default">#FFECF0F3</color>
     <color name="top_site_border">#FFCFD9E1</color>
 
-    <color name="private_active_text">#FFFFFF</color>
-
     <color name="action_bar_bg_color">@color/toolbar_grey</color>
 
     <color name="activity_stream_subtitle">#FF919191</color>
     <color name="activity_stream_icon">#FF919191</color>
 
     <color name="tablet_tab_strip_divider_color">#737373</color>
 
     <color name="bookmark_folder_bg_color">#FCFCFC</color>