Bug 1461693 - add missing params to changeInfo for tabs.onUpdated, r?rpl draft
authorShane Caraveo <scaraveo@mozilla.com>
Wed, 16 May 2018 10:16:40 -0500
changeset 795763 a42dfc0fe4e090f42eb6349796bceeb97b3b58e8
parent 795657 3c9d69736f4a421218e5eb01b6571d535d38318a
push id110067
push usermixedpuppy@gmail.com
push dateWed, 16 May 2018 15:17:23 +0000
reviewersrpl
bugs1461693
milestone62.0a1
Bug 1461693 - add missing params to changeInfo for tabs.onUpdated, r?rpl MozReview-Commit-ID: 1brjyYc7PwW
browser/components/extensions/schemas/tabs.json
--- a/browser/components/extensions/schemas/tabs.json
+++ b/browser/components/extensions/schemas/tabs.json
@@ -1393,50 +1393,73 @@
         "description": "Fired when a tab is updated.",
         "parameters": [
           {"type": "integer", "name": "tabId", "minimum": 0},
           {
             "type": "object",
             "name": "changeInfo",
             "description": "Lists the changes to the state of the tab that was updated.",
             "properties": {
-              "status": {
-                "type": "string",
+              "audible": {
+                "type": "boolean",
                 "optional": true,
-                "description": "The status of the tab. Can be either <em>loading</em> or <em>complete</em>."
+                "description": "The tab's new audible state."
               },
               "discarded": {
                 "type": "boolean",
                 "optional": true,
                 "description": "True while the tab is not loaded with content."
               },
-              "url": {
+              "favIconUrl": {
                 "type": "string",
                 "optional": true,
-                "description": "The tab's URL if it has changed."
+                "permissions": ["tabs"],
+                "description": "The tab's new favicon URL."
+              },
+              "hidden": {
+                "type": "boolean",
+                "optional": true,
+                "description": "The tab's new hidden state."
+              },
+              "isarticle": {
+                "type": "boolean",
+                "optional": true,
+                "description": "Whether the tab supports article mode."
+              },
+              "mutedInfo": {
+                "$ref": "MutedInfo",
+                "optional": true,
+                "description": "The tab's new muted state and the reason for the change."
               },
               "pinned": {
                 "type": "boolean",
                 "optional": true,
                 "description": "The tab's new pinned state."
               },
-              "audible": {
-                "type": "boolean",
+              "sharingState": {
+                "$ref": "SharingState",
                 "optional": true,
-                "description": "The tab's new audible state."
+                "description": "The tab's new sharing state for screen, microphone and camera."
               },
-              "mutedInfo": {
-                "$ref": "MutedInfo",
-                "optional": true,
-                "description": "The tab's new muted state and the reason for the change."
-              },
-              "favIconUrl": {
+              "status": {
                 "type": "string",
                 "optional": true,
-                "description": "The tab's new favicon URL."
+                "description": "The status of the tab. Can be either <em>loading</em> or <em>complete</em>."
+              },
+              "title": {
+                "type": "string",
+                "optional": true,
+                "permissions": ["tabs"],
+                "description": "The title of the tab if it has changed."
+              },
+              "url": {
+                "type": "string",
+                "optional": true,
+                "permissions": ["tabs"],
+                "description": "The tab's URL if it has changed."
               }
             }
           },
           {
             "$ref": "Tab",
             "name": "tab",
             "description": "Gives the state of the tab that was updated."
           }