Bug 1295103 - Check OriginAttributes::PopulateFromSuffix return value in SerializedLoadContext.. r=allstarschh draft
authorKan-Ru Chen <kanru@kanru.info>
Mon, 15 Aug 2016 18:15:23 +0800
changeset 404361 a2be4b396fbb483e0e8d01f2050f3031c002399e
parent 404131 24763f58772d45279a935790f732d80851924b46
child 404362 f1a53553352c7fb7b7659947dc0064b01cca0379
push id27198
push userbmo:kchen@mozilla.com
push dateTue, 23 Aug 2016 10:29:41 +0000
reviewersallstarschh
bugs1295103
milestone51.0a1
Bug 1295103 - Check OriginAttributes::PopulateFromSuffix return value in SerializedLoadContext.. r=allstarschh MozReview-Commit-ID: 8zIApW9e5q0
docshell/base/SerializedLoadContext.h
--- a/docshell/base/SerializedLoadContext.h
+++ b/docshell/base/SerializedLoadContext.h
@@ -82,17 +82,15 @@ struct ParamTraits<SerializedLoadContext
     if (!ReadParam(aMsg, aIter, &aResult->mIsNotNull) ||
         !ReadParam(aMsg, aIter, &aResult->mIsContent) ||
         !ReadParam(aMsg, aIter, &aResult->mIsPrivateBitValid) ||
         !ReadParam(aMsg, aIter, &aResult->mUsePrivateBrowsing) ||
         !ReadParam(aMsg, aIter, &aResult->mUseRemoteTabs) ||
         !ReadParam(aMsg, aIter, &suffix)) {
       return false;
     }
-    aResult->mOriginAttributes.PopulateFromSuffix(suffix);
-
-    return true;
+    return aResult->mOriginAttributes.PopulateFromSuffix(suffix);
   }
 };
 
 } // namespace IPC
 
 #endif // SerializedLoadContext_h