Bug 1419182 - Don't use mutable default argument value; r?build draft
authorGregory Szorc <gps@mozilla.com>
Mon, 20 Nov 2017 14:14:56 -0800
changeset 700832 a1794eb7a5e9ee38b1e8d4ce09251bfd12699f2b
parent 700831 88667475c01c4a458c42b3f93e592c2c24b4f2eb
child 700833 de698c205d3cfb555383e80b26d1c3caed8e52c0
push id89987
push userbmo:gps@mozilla.com
push dateMon, 20 Nov 2017 23:19:57 +0000
Bug 1419182 - Don't use mutable default argument value; r?build We always passed this argument in so this change doesn't fix any bugs. I just didn't like the code smell. MozReview-Commit-ID: IXzj1gRbkJ6
--- a/build/compare-mozconfig/compare-mozconfigs.py
+++ b/build/compare-mozconfig/compare-mozconfigs.py
@@ -37,17 +37,17 @@ def make_hg_url(hgHost, repoPath, protoc
 def readConfig(configfile):
     c = {}
     execfile(configfile, c)
     return c['whitelist']
 def verify_mozconfigs(mozconfig_pair, nightly_mozconfig_pair, platform,
-                      mozconfigWhitelist={}):
+                      mozconfigWhitelist):
     """Compares mozconfig to nightly_mozconfig and compare to an optional
     whitelist of known differences. mozconfig_pair and nightly_mozconfig_pair
     are pairs containing the mozconfig's identifier and the list of lines in
     the mozconfig."""
     # unpack the pairs to get the names, the names are just for
     # identifying the mozconfigs when logging the error messages
     mozconfig_name, mozconfig_lines = mozconfig_pair