Bug 1402170 - Update some test descriptions; r?hiro draft
authorBrian Birtles <birtles@gmail.com>
Fri, 22 Sep 2017 11:54:50 +0900
changeset 668837 a0d6413f5a78c797dce3b13d5ca37068fa31a524
parent 668836 eb1cf9372933e77ed5050a5faab52d7ec37bccb5
child 732784 538819652fbb60e642f16cc8b8f105d0a612ff8a
push id81132
push userbbirtles@mozilla.com
push dateFri, 22 Sep 2017 02:57:12 +0000
reviewershiro
bugs1402170
milestone58.0a1
Bug 1402170 - Update some test descriptions; r?hiro * We should refer to reading or accessing properties, as opposed to "considering" them. * We should use "property-indexed" consistently. MozReview-Commit-ID: ItCE4g8LmOC
testing/web-platform/tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument.html
--- a/testing/web-platform/tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument.html
+++ b/testing/web-platform/tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument.html
@@ -74,17 +74,17 @@ for (const prop of gNonAnimatableProps) 
 
     new KeyframeEffect(null, testKeyframes);
 
     assert_equals(testKeyframes[0].propAccessCount, 0, 'Accessor not called');
   }, `non-animatable property '${prop}' is not accessed when using`
      + ' a keyframe sequence');
 }
 
-// Test equivalent forms of property indexed and sequenced keyframe syntax
+// Test equivalent forms of property-indexed and sequenced keyframe syntax
 
 function assertEquivalentKeyframeSyntax(keyframesA, keyframesB) {
   const processedKeyframesA =
     new KeyframeEffect(null, keyframesA).getKeyframes();
   const processedKeyframesB =
     new KeyframeEffect(null, keyframesB).getKeyframes();
   assert_frame_lists_equal(processedKeyframesA, processedKeyframesB);
 }
@@ -149,17 +149,17 @@ const gEquivalentSyntaxTests = [
     ],
   },
 ];
 
 for (const {description, indexedKeyframes, sequencedKeyframes} of
      gEquivalentSyntaxTests) {
   test(function(t) {
     assertEquivalentKeyframeSyntax(indexedKeyframes, sequencedKeyframes);
-  }, `Equivalent property indexed and sequenced keyframes ${description}`);
+  }, `Equivalent property-indexed and sequenced keyframes ${description}`);
 }
 
 // Test handling of custom iterable objects.
 
 function createIterable(iterations) {
   return {
     [Symbol.iterator]() {
       let i = 0;
@@ -263,17 +263,17 @@ test(function(t) {
   assert_equals(keyframe.height, '100px', 'height of keyframe is readable');
 
   const effect = new KeyframeEffect(null, [keyframe, {height: '200px'}]);
 
   assert_frame_lists_equal(effect.getKeyframes(), [
     {offset: null, computedOffset: 0, easing: 'linear', height: '100px'},
     {offset: null, computedOffset: 1, easing: 'linear', height: '200px'},
   ]);
-}, 'Only enumerable properties on keyframes are considered');
+}, 'Only enumerable properties on keyframes are read');
 
 test(function(t) {
   const KeyframeParent = function() { this.width = '100px'; };
   KeyframeParent.prototype = { height: '100px' };
   const Keyframe = function() { this.top = '100px'; };
   Keyframe.prototype = Object.create(KeyframeParent.prototype);
   Object.defineProperty(Keyframe.prototype, 'left', {
     value: '100px',
@@ -281,32 +281,32 @@ test(function(t) {
   const keyframe = new Keyframe();
 
   const effect = new KeyframeEffect(null, [keyframe, {top: '200px'}]);
 
   assert_frame_lists_equal(effect.getKeyframes(), [
     {offset: null, computedOffset: 0, easing: 'linear', top: '100px'},
     {offset: null, computedOffset: 1, easing: 'linear', top: '200px'},
   ]);
-}, 'Only properties defined directly on keyframes are considered');
+}, 'Only properties defined directly on keyframes are read');
 
 test(function(t) {
   const keyframes = {};
   Object.defineProperty(keyframes, 'width', ['100px', '200px']);
   Object.defineProperty(keyframes, 'height', {
     value: ['100px', '200px'],
     enumerable: true});
 
   const effect = new KeyframeEffect(null, keyframes);
 
   assert_frame_lists_equal(effect.getKeyframes(), [
     {offset: null, computedOffset: 0, easing: 'linear', height: '100px'},
     {offset: null, computedOffset: 1, easing: 'linear', height: '200px'},
   ]);
-}, 'Only enumerable properties on property indexed keyframes are considered');
+}, 'Only enumerable properties on property-indexed keyframes are read');
 
 test(function(t) {
   const KeyframesParent = function() { this.width = '100px'; };
   KeyframesParent.prototype = { height: '100px' };
   const Keyframes = function() { this.top = ['100px', '200px']; };
   Keyframes.prototype = Object.create(KeyframesParent.prototype);
   Object.defineProperty(Keyframes.prototype, 'left', {
     value: ['100px', '200px'],
@@ -314,16 +314,16 @@ test(function(t) {
   const keyframes = new Keyframes();
 
   const effect = new KeyframeEffect(null, keyframes);
 
   assert_frame_lists_equal(effect.getKeyframes(), [
     {offset: null, computedOffset: 0, easing: 'linear', top: '100px'},
     {offset: null, computedOffset: 1, easing: 'linear', top: '200px'},
   ]);
-}, 'Only properties defined directly on property indexed keyframes are considered');
+}, 'Only properties defined directly on property-indexed keyframes are read');
 
 // FIXME: Test that properties are accessed in ascending order by Unicode
 //        codepoint
 //        (There is an existing test for this in
 //        keyframe-effect/constructor.html that should be moved here.)
 
 </script>